Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5687)

Unified Diff: chrome/test/data/webui/md_bookmarks/command_manager_test.js

Issue 2940233003: MD Bookmarks: Lazily render dropdown menus (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_bookmarks/command_manager_test.js
diff --git a/chrome/test/data/webui/md_bookmarks/command_manager_test.js b/chrome/test/data/webui/md_bookmarks/command_manager_test.js
index eb844b95d965ba26e534712ee4a8b6d8203ac54b..91fa8f1393d2f6b0066770f6f3181636cc0f1db3 100644
--- a/chrome/test/data/webui/md_bookmarks/command_manager_test.js
+++ b/chrome/test/data/webui/md_bookmarks/command_manager_test.js
@@ -50,8 +50,6 @@ suite('<bookmarks-command-manager>', function() {
replaceBody(commandManager);
document.body.appendChild(
document.createElement('bookmarks-toast-manager'));
-
- Polymer.dom.flush();
});
test('can only copy single URL items', function() {
@@ -65,6 +63,8 @@ suite('<bookmarks-command-manager>', function() {
store.notifyObservers();
commandManager.openCommandMenuAtPosition(0, 0);
+ Polymer.dom.flush();
+
var commandHidden = {};
commandManager.root.querySelectorAll('.dropdown-item').forEach(element => {
commandHidden[element.getAttribute('command')] = element.hidden;
@@ -188,6 +188,8 @@ suite('<bookmarks-command-manager>', function() {
store.data.selection.items = items;
commandManager.openCommandMenuAtPosition(0, 0);
+ Polymer.dom.flush();
+
var commandItem = {};
commandManager.root.querySelectorAll('.dropdown-item').forEach(element => {
commandItem[element.getAttribute('command')] = element;
« no previous file with comments | « chrome/browser/resources/md_bookmarks/toolbar.js ('k') | chrome/test/data/webui/md_bookmarks/toolbar_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698