Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4618)

Unified Diff: chrome/browser/resources/md_bookmarks/toolbar.html

Issue 2940233003: MD Bookmarks: Lazily render dropdown menus (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/toolbar.html
diff --git a/chrome/browser/resources/md_bookmarks/toolbar.html b/chrome/browser/resources/md_bookmarks/toolbar.html
index 6668404b2dfa85c4f53a9a0fa56a90e6540df813..529b3bdbd93a5fc8f15fc499edd40cb0fc223b26 100644
--- a/chrome/browser/resources/md_bookmarks/toolbar.html
+++ b/chrome/browser/resources/md_bookmarks/toolbar.html
@@ -46,42 +46,46 @@
--selection-overlay-max-width: var(--card-max-width);
}
</style>
- <dialog is="cr-action-menu" id="dropdown">
- <button class="dropdown-item" on-tap="onSortTap_"
- disabled="[[!canChangeList_]]">
- $i18n{menuSort}
- </button>
- <hr>
- <button id="addBookmarkButton" class="dropdown-item"
- on-tap="onAddBookmarkTap_" disabled="[[!canChangeList_]]">
- $i18n{menuAddBookmark}
- </button>
- <button class="dropdown-item" on-tap="onAddFolderTap_"
- disabled="[[!canChangeList_]]">
- $i18n{menuAddFolder}
- </button>
- <hr>
- <button id="importBookmarkButton" class="dropdown-item"
- on-tap="onImportTap_" disabled="[[!globalCanEdit_]]">
- $i18n{menuImport}
- </button>
- <button class="dropdown-item" on-tap="onExportTap_">
- $i18n{menuExport}
- </button>
- </dialog>
<cr-toolbar page-name="$i18n{title}"
clear-label="$i18n{clearSearch}"
search-prompt="$i18n{searchPrompt}"
hidden$="[[showSelectionOverlay]]"
narrow="{{narrow_}}"
on-search-changed="onSearchChanged_">
- <button is="paper-icon-button-light" class="more-actions more-vert-button"
+ <button is="paper-icon-button-light"
+ id="menuButton"
+ class="more-actions more-vert-button"
on-tap="onMenuButtonOpenTap_">
<div></div>
<div></div>
<div></div>
</button>
</cr-toolbar>
+ <template is="cr-lazy-render" id="dropdown">
+ <dialog is="cr-action-menu">
+ <button class="dropdown-item" on-tap="onSortTap_"
+ disabled="[[!canChangeList_]]">
+ $i18n{menuSort}
+ </button>
+ <hr>
+ <button id="addBookmarkButton" class="dropdown-item"
+ on-tap="onAddBookmarkTap_" disabled="[[!canChangeList_]]">
+ $i18n{menuAddBookmark}
+ </button>
+ <button class="dropdown-item" on-tap="onAddFolderTap_"
+ disabled="[[!canChangeList_]]">
+ $i18n{menuAddFolder}
+ </button>
+ <hr>
+ <button id="importBookmarkButton" class="dropdown-item"
+ on-tap="onImportTap_" disabled="[[!globalCanEdit_]]">
+ $i18n{menuImport}
+ </button>
+ <button class="dropdown-item" on-tap="onExportTap_">
+ $i18n{menuExport}
+ </button>
+ </dialog>
+ </template>
<template is="cr-lazy-render" id="addDialog">
<bookmarks-edit-dialog></bookmarks-edit-dialog>
</template>
« no previous file with comments | « chrome/browser/resources/md_bookmarks/compiled_resources2.gyp ('k') | chrome/browser/resources/md_bookmarks/toolbar.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698