MD Bookmarks: Fix issue where keyboard shortcuts could fire incorrectly

MD Bookmarks: Fix issue where keyboard shortcuts could fire incorrectly

MD Bookmarks did not correctly distinguish between a keypress of 'Enter'
vs 'Shift-Enter', meaning that someone trying to 'Open in new window'
could instead 'Edit' or 'Open', depending on platform.

This fixes the issue by moving shortcut handling from iron-a11y-keys
to using the standard WebUI Command handlers.

BUG=731531
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2939873004
Cr-Commit-Position: refs/heads/master@{#479940}
Committed: https://chromium.googlesource.com/chromium/src/+/0292e51a152b3209d4aa203c265a513bf75bc321

[tsergeant, 2017-06-14 01:45:06]

Description was changed from

==========
MD Bookmarks: Fix issue where incorrect keyboard shortcuts could fire

MD Bookmarks did not correctly distinguish between a keypress of 'Enter'
vs 'Shift-Enter', meaning that someone trying to 'Open in new window'
could instead 'Edit' or 'Open', depending on platform.

This fixes the issue by moving shortcut handling from iron-a11y-keys
to using the standard WebUI Command handlers.

BUG=731531
==========

to

==========
MD Bookmarks: Fix issue where incorrect keyboard shortcuts could fire

MD Bookmarks did not correctly distinguish between a keypress of 'Enter'
vs 'Shift-Enter', meaning that someone trying to 'Open in new window'
could instead 'Edit' or 'Open', depending on platform.

This fixes the issue by moving shortcut handling from iron-a11y-keys
to using the standard WebUI Command handlers.

BUG=731531
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-06-14 01:45:55]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 01:46:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-06-14 01:48:50]

Description was changed from

==========
MD Bookmarks: Fix issue where incorrect keyboard shortcuts could fire

MD Bookmarks did not correctly distinguish between a keypress of 'Enter'
vs 'Shift-Enter', meaning that someone trying to 'Open in new window'
could instead 'Edit' or 'Open', depending on platform.

This fixes the issue by moving shortcut handling from iron-a11y-keys
to using the standard WebUI Command handlers.

BUG=731531
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Fix issue where keyboard shortcuts could fire incorrectly

MD Bookmarks did not correctly distinguish between a keypress of 'Enter'
vs 'Shift-Enter', meaning that someone trying to 'Open in new window'
could instead 'Edit' or 'Open', depending on platform.

This fixes the issue by moving shortcut handling from iron-a11y-keys
to using the standard WebUI Command handlers.

BUG=731531
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-06-14 01:51:01]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[commit-bot: I haz the power, 2017-06-14 02:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 02:28:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tsergeant, 2017-06-14 02:52:30]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 02:52:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 02:54:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 02:54:51]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tsergeant, 2017-06-14 03:11:41]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 03:11:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 04:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 04:10:27]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[calamity, 2017-06-15 04:28:40]

lg % mac test.

[tsergeant, 2017-06-15 06:01:52]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 06:01:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-06-15 06:58:26]

Mac test has been fixed (keyboard shortcuts are case-sensitive now)

[commit-bot: I haz the power, 2017-06-15 07:13:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 07:13:58]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-06-16 03:32:04]

lgtm

[tsergeant, 2017-06-16 03:39:42]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-06-16 03:40:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 03:44:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497584382887650,
"parent_rev": "7ffbc84c441d02291f786b28cffca262b42b0c90", "commit_rev":
"0292e51a152b3209d4aa203c265a513bf75bc321"}

[commit-bot: I haz the power, 2017-06-16 03:44:48]

Description was changed from

==========
MD Bookmarks: Fix issue where keyboard shortcuts could fire incorrectly

MD Bookmarks did not correctly distinguish between a keypress of 'Enter'
vs 'Shift-Enter', meaning that someone trying to 'Open in new window'
could instead 'Edit' or 'Open', depending on platform.

This fixes the issue by moving shortcut handling from iron-a11y-keys
to using the standard WebUI Command handlers.

BUG=731531
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Fix issue where keyboard shortcuts could fire incorrectly

MD Bookmarks did not correctly distinguish between a keypress of 'Enter'
vs 'Shift-Enter', meaning that someone trying to 'Open in new window'
could instead 'Edit' or 'Open', depending on platform.

This fixes the issue by moving shortcut handling from iron-a11y-keys
to using the standard WebUI Command handlers.

BUG=731531
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2939873004
Cr-Commit-Position: refs/heads/master@{#479940}
Committed:
https://chromium.googlesource.com/chromium/src/+/0292e51a152b3209d4aa203c265a...
==========

[commit-bot: I haz the power, 2017-06-16 03:44:50]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0292e51a152b3209d4aa203c265a...