chrome/browser/resources/md_bookmarks/command_manager.html - Issue 2939873004: MD Bookmarks: Fix issue where keyboard shortcuts could fire incorrectly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_bookmarks/command_manager.html

Issue 2939873004: MD Bookmarks: Fix issue where keyboard shortcuts could fire incorrectly (Closed)

Patch Set: Fix mac test? Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2	2

3 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">	3 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">

4 <link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_r ender.html">	4 <link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_r ender.html">

	5 <link rel="import" href="chrome://resources/html/cr/ui/command.html">

5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys-behavior /iron-a11y-keys-behavior.html">	6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys-behavior /iron-a11y-keys-behavior.html">

6 <link rel="import" href="chrome://bookmarks/edit_dialog.html">	7 <link rel="import" href="chrome://bookmarks/edit_dialog.html">

7 <link rel="import" href="chrome://bookmarks/shared_style.html">	8 <link rel="import" href="chrome://bookmarks/shared_style.html">

8 <link rel="import" href="chrome://bookmarks/store_client.html">	9 <link rel="import" href="chrome://bookmarks/store_client.html">

9	10

10 <dom-module id="bookmarks-command-manager">	11 <dom-module id="bookmarks-command-manager">

11 <template>	12 <template>

12 <style include="shared-style"></style>	13 <style include="shared-style"></style>

13 <dialog is="cr-action-menu" id="dropdown" on-mousedown="onMenuMousedown_">	14 <dialog is="cr-action-menu" id="dropdown" on-mousedown="onMenuMousedown_">

14 <template is="dom-repeat" items="[[menuCommands_]]" as="command">	15 <template is="dom-repeat" items="[[menuCommands_]]" as="command">

15 <button class="dropdown-item"	16 <button class="dropdown-item"

16 command$="[[command]]"	17 command$="[[command]]"

17 hidden$="[[!isCommandVisible_(command, menuIds_)]]"	18 hidden$="[[!isCommandVisible_(command, menuIds_)]]"

18 disabled$="[[!isCommandEnabled_(command, menuIds_)]]"	19 disabled$="[[!isCommandEnabled_(command, menuIds_)]]"

19 on-tap="onCommandClick_">	20 on-tap="onCommandClick_">

20 [[getCommandLabel_(command, menuIds_)]]	21 [[getCommandLabel_(command, menuIds_)]]

21 </button>	22 </button>

22 <hr hidden$="[[!showDividerAfter_(command, menuIds_)]]"></hr>	23 <hr hidden$="[[!showDividerAfter_(command, menuIds_)]]"></hr>

23 </template>	24 </template>

24 </dialog>	25 </dialog>

25 <template is="cr-lazy-render" id="editDialog">	26 <template is="cr-lazy-render" id="editDialog">

26 <bookmarks-edit-dialog></bookmarks-edit-dialog>	27 <bookmarks-edit-dialog></bookmarks-edit-dialog>

27 </template>	28 </template>

28 </template>	29 </template>

29 <script src="chrome://bookmarks/command_manager.js"></script>	30 <script src="chrome://bookmarks/command_manager.js"></script>

30 </dom-module>	31 </dom-module>

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/resources/md_bookmarks/command_manager.js » ('j') | no next file with comments »