Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 2929053004: MD Bookmarks: Make shortcuts for select all/deselect all global (Closed)

Created:
3 years, 6 months ago by tsergeant
Modified:
3 years, 6 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Make shortcuts for select all/deselect all global These shortcuts (Ctrl/Meta-A and Escape) can now be triggered while the sidebar or document are active. BUG=730405 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2929053004 Cr-Commit-Position: refs/heads/master@{#479975} Committed: https://chromium.googlesource.com/chromium/src/+/679159f7fd567e7c1953a1c1548ee42ae55d2907

Patch Set 1 #

Patch Set 2 : Reparent, fix test #

Patch Set 3 : Fix test flub #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M chrome/browser/resources/md_bookmarks/command_manager.js View 1 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/constants.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.js View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js View 1 2 5 chunks +5 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (18 generated)
tsergeant
3 years, 6 months ago (2017-06-09 05:51:27 UTC) #6
tsergeant
On 2017/06/09 05:51:27, tsergeant wrote: I'll look into the failing tests next week.
3 years, 6 months ago (2017-06-09 06:48:35 UTC) #9
tsergeant
Alright, the tests are fixed, PTAL.
3 years, 6 months ago (2017-06-14 03:47:58 UTC) #11
calamity
lgtm, update CL description (refactor moved upstream?)
3 years, 6 months ago (2017-06-15 04:32:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929053004/20001
3 years, 6 months ago (2017-06-16 03:56:16 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/478681)
3 years, 6 months ago (2017-06-16 05:04:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929053004/40001
3 years, 6 months ago (2017-06-16 05:13:59 UTC) #23
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 06:58:54 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/679159f7fd567e7c1953a1c1548e...

Powered by Google App Engine
This is Rietveld 408576698