Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2939173002: Reland of [DevTools] Show icon in top toolbar when Node target is available (Closed)

Created:
3 years, 6 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [DevTools] Show icon in top toolbar when Node target is available (patchset #1 id:1 of https://codereview.chromium.org/2932703002/ ) Reason for revert: Fixed the original crash cause Original issue's description: > Revert of [DevTools] Show icon in top toolbar when Node target is available (patchset #3 id:40001 of https://codereview.chromium.org/2890973002/ ) > > Reason for revert: > See issue 727517 > > Original issue's description: > > [DevTools] Show icon in top toolbar when Node target is available > > > > Clicking on it opens dedicated Node frontend. > > > > BUG=706916 > > > > Review-Url: https://codereview.chromium.org/2890973002 > > Cr-Commit-Position: refs/heads/master@{#472739} > > Committed: https://chromium.googlesource.com/chromium/src/+/ad3ffab411cc396ffb20c1d35dcff6de038f14b4 > > TBR=pfeldman@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=706916 > > Review-Url: https://codereview.chromium.org/2932703002 > Cr-Commit-Position: refs/heads/master@{#478017} > Committed: https://chromium.googlesource.com/chromium/src/+/24309d877571d159bc14f871671ff0630d6f8d32 TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=706916, 727517 Review-Url: https://codereview.chromium.org/2939173002 Cr-Commit-Position: refs/heads/master@{#479882} Committed: https://chromium.googlesource.com/chromium/src/+/ed459c553934485a18180313d892f53dfd4eae94

Patch Set 1 #

Messages

Total messages: 11 (6 generated)
dgozman
Created Reland of [DevTools] Show icon in top toolbar when Node target is available
3 years, 6 months ago (2017-06-15 20:27:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939173002/1
3 years, 6 months ago (2017-06-15 20:28:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/118412)
3 years, 6 months ago (2017-06-15 20:42:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939173002/1
3 years, 6 months ago (2017-06-15 22:09:10 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 23:02:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ed459c553934485a18180313d892...

Powered by Google App Engine
This is Rietveld 408576698