Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2932703002: Revert of [DevTools] Show icon in top toolbar when Node target is available (Closed)

Created:
3 years, 6 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Show icon in top toolbar when Node target is available (patchset #3 id:40001 of https://codereview.chromium.org/2890973002/ ) Reason for revert: See issue 727517 Original issue's description: > [DevTools] Show icon in top toolbar when Node target is available > > Clicking on it opens dedicated Node frontend. > > BUG=706916 > > Review-Url: https://codereview.chromium.org/2890973002 > Cr-Commit-Position: refs/heads/master@{#472739} > Committed: https://chromium.googlesource.com/chromium/src/+/ad3ffab411cc396ffb20c1d35dcff6de038f14b4 TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=706916 Review-Url: https://codereview.chromium.org/2932703002 Cr-Commit-Position: refs/heads/master@{#478017} Committed: https://chromium.googlesource.com/chromium/src/+/24309d877571d159bc14f871671ff0630d6f8d32

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
dgozman
Created Revert of [DevTools] Show icon in top toolbar when Node target is available
3 years, 6 months ago (2017-06-08 15:16:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932703002/1
3 years, 6 months ago (2017-06-08 15:16:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/24309d877571d159bc14f871671ff0630d6f8d32
3 years, 6 months ago (2017-06-08 17:49:06 UTC) #6
dgozman
3 years, 6 months ago (2017-06-15 20:27:49 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2939173002/ by dgozman@chromium.org.

The reason for reverting is: Fixed the original crash cause.

Powered by Google App Engine
This is Rietveld 408576698