Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2890973002: [DevTools] Show icon in top toolbar when Node target is available (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Show icon in top toolbar when Node target is available Clicking on it opens dedicated Node frontend. BUG=706916 Review-Url: https://codereview.chromium.org/2890973002 Cr-Commit-Position: refs/heads/master@{#472739} Committed: https://chromium.googlesource.com/chromium/src/+/ad3ffab411cc396ffb20c1d35dcff6de038f14b4

Patch Set 1 #

Patch Set 2 : green/gray #

Patch Set 3 : better, with hover #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -59 lines) Patch
M chrome/browser/devtools/devtools_window.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 3 chunks +13 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/target_handler.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/target_handler.cc View 1 2 3 chunks +22 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/Images/nodeIcon.png View Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/module.json View 2 chunks +8 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/main/nodeIcon.css View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 4 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js View 2 chunks +1 line, -28 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/threadsSidebarPane.css View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dgozman
Take a look please.
3 years, 7 months ago (2017-05-17 23:33:39 UTC) #2
pfeldman
lgtm
3 years, 7 months ago (2017-05-17 23:53:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890973002/40001
3 years, 7 months ago (2017-05-18 01:34:00 UTC) #10
paulirish
this is so great.
3 years, 7 months ago (2017-05-18 02:44:43 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ad3ffab411cc396ffb20c1d35dcff6de038f14b4
3 years, 7 months ago (2017-05-18 08:23:12 UTC) #14
dgozman
3 years, 6 months ago (2017-06-08 15:16:13 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2932703002/ by dgozman@chromium.org.

The reason for reverting is: See issue 727517.

Powered by Google App Engine
This is Rietveld 408576698