Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2939123002: Revert of Add blink::WebSocketHandshakeThrottle (Closed)

Created:
3 years, 6 months ago by brettw
Modified:
3 years, 6 months ago
Reviewers:
haraken, Adam Rice, yhirano
CC:
chromium-reviews, tyoshino+watch_chromium.org, yhirano+watch_chromium.org, blink-reviews, dglazkov+blink, haraken, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add blink::WebSocketHandshakeThrottle (patchset #3 id:40001 of https://codereview.chromium.org/2930263002/ ) Reason for revert: New header not added to build causes failures: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_rel_ng%2F479687%2F%2B%2Frecipes%2Fsteps%2Fcheck_gn_headers__with_patch_%2F0%2Fstdout Original issue's description: > Add blink::WebSocketHandshakeThrottle > > Add a facility for WebSocket handshakes to be delayed or cancelled by the > embedder. By implementing blink::Platform::CreateWebSocketHandshakeThrottle() > the embedder can supply an implementation of blink::WebSocketHandshakeThrottle > to throttle WebSocket handshakes. > > To avoid slowing down the normal case, the throttling runs in parallel with the > handshake. Only access to the new connection from Javascript is delayed. > > The default behaviour is to have no throttling. > > The implementation is in > blink::DocumentWebSocketChannel. DocumentWebSocketChannelTest has new tests for > the new functionality. > > This is part of the implementation of Safe Browsing for WebSockets. See the > design doc at > https://docs.google.com/document/d/1iR3XMIQukqlXb6ajIHE91apHZAxyF_wvRoB5JGeJYPs/edit > > BUG=644744 > > Review-Url: https://codereview.chromium.org/2930263002 > Cr-Commit-Position: refs/heads/master@{#479709} > Committed: https://chromium.googlesource.com/chromium/src/+/bf9d1c2f8e5ea0366b4b086c7d0541bdc15ab176 TBR=yhirano@chromium.org,haraken@chromium.org,ricea@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=644744 Review-Url: https://codereview.chromium.org/2939123002 Cr-Commit-Position: refs/heads/master@{#479750} Committed: https://chromium.googlesource.com/chromium/src/+/82ffd4eac8d6534797d2c42fca69a8f158d3bd73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -434 lines) Patch
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h View 6 chunks +14 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 12 chunks +4 lines, -88 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 8 chunks +6 lines, -253 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 3 chunks +0 lines, -10 lines 0 comments Download
D third_party/WebKit/public/platform/WebSocketHandshakeThrottle.h View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
brettw
Created Revert of Add blink::WebSocketHandshakeThrottle
3 years, 6 months ago (2017-06-15 17:43:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939123002/1
3 years, 6 months ago (2017-06-15 17:44:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/82ffd4eac8d6534797d2c42fca69a8f158d3bd73
3 years, 6 months ago (2017-06-15 17:44:48 UTC) #6
Adam Rice
3 years, 6 months ago (2017-06-16 10:20:03 UTC) #7
Message was sent while issue was closed.
On 2017/06/15 17:44:48, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/82ffd4eac8d6534797d2c42fca69...

Relanded with BUILD.gn fix at https://codereview.chromium.org/2942173002

Powered by Google App Engine
This is Rietveld 408576698