Chromium Code Reviews
DescriptionRevert of Add blink::WebSocketHandshakeThrottle (patchset #3 id:40001 of https://codereview.chromium.org/2930263002/ )
Reason for revert:
New header not added to build causes failures:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_rel_ng%2F479687%2F%2B%2Frecipes%2Fsteps%2Fcheck_gn_headers__with_patch_%2F0%2Fstdout
Original issue's description:
> Add blink::WebSocketHandshakeThrottle
>
> Add a facility for WebSocket handshakes to be delayed or cancelled by the
> embedder. By implementing blink::Platform::CreateWebSocketHandshakeThrottle()
> the embedder can supply an implementation of blink::WebSocketHandshakeThrottle
> to throttle WebSocket handshakes.
>
> To avoid slowing down the normal case, the throttling runs in parallel with the
> handshake. Only access to the new connection from Javascript is delayed.
>
> The default behaviour is to have no throttling.
>
> The implementation is in
> blink::DocumentWebSocketChannel. DocumentWebSocketChannelTest has new tests for
> the new functionality.
>
> This is part of the implementation of Safe Browsing for WebSockets. See the
> design doc at
> https://docs.google.com/document/d/1iR3XMIQukqlXb6ajIHE91apHZAxyF_wvRoB5JGeJYPs/edit
>
> BUG=644744
>
> Review-Url: https://codereview.chromium.org/2930263002
> Cr-Commit-Position: refs/heads/master@{#479709}
> Committed: https://chromium.googlesource.com/chromium/src/+/bf9d1c2f8e5ea0366b4b086c7d0541bdc15ab176
TBR=yhirano@chromium.org,haraken@chromium.org,ricea@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644744
Review-Url: https://codereview.chromium.org/2939123002
Cr-Commit-Position: refs/heads/master@{#479750}
Committed: https://chromium.googlesource.com/chromium/src/+/82ffd4eac8d6534797d2c42fca69a8f158d3bd73
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||