Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2942173002: Reland of "Add blink::WebSocketHandshakeThrottle" (Closed)

Created:
3 years, 6 months ago by Adam Rice
Modified:
3 years, 6 months ago
Reviewers:
haraken, yhirano
CC:
chromium-reviews, tyoshino+watch_chromium.org, yhirano+watch_chromium.org, blink-reviews, dglazkov+blink, haraken, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Add blink::WebSocketHandshakeThrottle" The CL has been updated to add WebSocketHandshakeThrottle.h to BUILD.gn. Otherwise it is identical to the original CL, https://codereview.chromium.org/2930263002/, which was reverted. Original description: Add a facility for WebSocket handshakes to be delayed or cancelled by the embedder. By implementing blink::Platform::CreateWebSocketHandshakeThrottle() the embedder can supply an implementation of blink::WebSocketHandshakeThrottle to throttle WebSocket handshakes. To avoid slowing down the normal case, the throttling runs in parallel with the handshake. Only access to the new connection from Javascript is delayed. The default behaviour is to have no throttling. The implementation is in blink::DocumentWebSocketChannel. DocumentWebSocketChannelTest has new tests for the new functionality. This is part of the implementation of Safe Browsing for WebSockets. See the design doc at https://docs.google.com/document/d/1iR3XMIQukqlXb6ajIHE91apHZAxyF_wvRoB5JGeJYPs/edit BUG=644744 TBR=yhirano,haraken Review-Url: https://codereview.chromium.org/2942173002 Cr-Commit-Position: refs/heads/master@{#479991} Committed: https://chromium.googlesource.com/chromium/src/+/3df1a00a1b61c1663e1183f54cb2d6a0badb26ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -24 lines) Patch
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h View 6 chunks +31 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 12 chunks +88 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 8 chunks +253 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 3 chunks +10 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/WebSocketHandshakeThrottle.h View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942173002/1
3 years, 6 months ago (2017-06-16 05:53:05 UTC) #2
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 08:15:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3df1a00a1b61c1663e1183f54cb2...

Powered by Google App Engine
This is Rietveld 408576698