Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 2938553003: Revert of [sync] Replace FakeServer's implementation with LoopbackServer invocations. (Closed)

Created:
3 years, 6 months ago by Henrik Grunell
Modified:
3 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, chromium-apps-reviews_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [sync] Replace FakeServer's implementation with LoopbackServer invocations. (patchset #8 id:140001 of https://codereview.chromium.org/2909173003/ ) Reason for revert: Breaks several bots. Example: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/57987 Original issue's description: > Replace FakeServer's implementation with LoopbackServer invocations. > > This makes FakeServer a debugging adapter for LoopbackServer. It mostly > forwards calls to the actual implementation in the LoopbackServer but > also allows for simulating various exceptional conditions and deeper > ispection in the data flow. > > BUG=651415 > TEST=All tests still pass. > > Review-Url: https://codereview.chromium.org/2909173003 > Cr-Commit-Position: refs/heads/master@{#478921} > Committed: https://chromium.googlesource.com/chromium/src/+/4993d7744127a9b1367c2834908d97397a372c29 TBR=zea@chromium.org,baxley@chromium.org,pastarmovj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=651415 Review-Url: https://codereview.chromium.org/2938553003 Cr-Commit-Position: refs/heads/master@{#478944} Committed: https://chromium.googlesource.com/chromium/src/+/3806e2ca7233962157119ad8ac1768fc528013b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1498 lines, -340 lines) Patch
M chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_password_manager_setting_migrator_service_sync_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/sync/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server.h View 5 chunks +0 lines, -53 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server.cc View 7 chunks +6 lines, -106 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server_entity.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_permanent_entity.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_tombstone_entity.h View 2 chunks +2 lines, -10 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_tombstone_entity.cc View 2 chunks +5 lines, -20 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_unique_client_entity.h View 1 chunk +1 line, -7 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc View 3 chunks +1 line, -17 lines 0 comments Download
M components/sync/test/fake_server/android/fake_server_helper_android.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/test/fake_server/android/fake_server_helper_android.cc View 6 chunks +10 lines, -7 lines 0 comments Download
A components/sync/test/fake_server/bookmark_entity.h View 1 chunk +75 lines, -0 lines 0 comments Download
A components/sync/test/fake_server/bookmark_entity.cc View 1 chunk +119 lines, -0 lines 0 comments Download
M components/sync/test/fake_server/bookmark_entity_builder.h View 2 chunks +9 lines, -9 lines 0 comments Download
M components/sync/test/fake_server/bookmark_entity_builder.cc View 5 chunks +12 lines, -15 lines 0 comments Download
M components/sync/test/fake_server/fake_server.h View 6 chunks +75 lines, -16 lines 0 comments Download
M components/sync/test/fake_server/fake_server.cc View 7 chunks +495 lines, -51 lines 0 comments Download
A components/sync/test/fake_server/fake_server_entity.h View 1 chunk +91 lines, -0 lines 0 comments Download
A components/sync/test/fake_server/fake_server_entity.cc View 1 chunk +130 lines, -0 lines 0 comments Download
A components/sync/test/fake_server/permanent_entity.h View 1 chunk +63 lines, -0 lines 0 comments Download
A components/sync/test/fake_server/permanent_entity.cc View 1 chunk +105 lines, -0 lines 0 comments Download
A components/sync/test/fake_server/tombstone_entity.h View 1 chunk +41 lines, -0 lines 0 comments Download
A components/sync/test/fake_server/tombstone_entity.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A components/sync/test/fake_server/unique_client_entity.h View 1 chunk +68 lines, -0 lines 0 comments Download
A components/sync/test/fake_server/unique_client_entity.cc View 1 chunk +102 lines, -0 lines 0 comments Download
M ios/chrome/test/app/sync_test_util.mm View 5 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Henrik Grunell
Created Revert of [sync] Replace FakeServer's implementation with LoopbackServer invocations.
3 years, 6 months ago (2017-06-13 09:07:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938553003/1
3 years, 6 months ago (2017-06-13 09:08:00 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 09:08:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3806e2ca7233962157119ad8ac17...

Powered by Google App Engine
This is Rietveld 408576698