components/sync/engine_impl/loopback_server/loopback_server_entity.cc - Issue 2938553003: Revert of [sync] Replace FakeServer's implementation with LoopbackServer invocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/loopback_server/loopback_server_entity.cc

Issue 2938553003: Revert of [sync] Replace FakeServer's implementation with LoopbackServer invocations. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync/engine_impl/loopback_server/loopback_server.cc ('k') | components/sync/engine_impl/loopback_server/persistent_permanent_entity.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/engine_impl/loopback_server/loopback_server_entity.cc

diff --git a/components/sync/engine_impl/loopback_server/loopback_server_entity.cc b/components/sync/engine_impl/loopback_server/loopback_server_entity.cc

index 946fd9402757da30f121249de16d26b36b446362..c6e20fe12abd2d7ec8c501d2d36327f3cfb27ec1 100644

--- a/components/sync/engine_impl/loopback_server/loopback_server_entity.cc

+++ b/components/sync/engine_impl/loopback_server/loopback_server_entity.cc

@@ -46,7 +46,7 @@

const sync_pb::LoopbackServerEntity& entity) {

switch (entity.type()) {

case sync_pb::LoopbackServerEntity_Type_TOMBSTONE:

- return PersistentTombstoneEntity::CreateFromEntity(entity.entity());

+ return PersistentTombstoneEntity::Create(entity.entity());

case sync_pb::LoopbackServerEntity_Type_PERMANENT:

return base::MakeUnique<PersistentPermanentEntity>(

entity.entity().id_string(), entity.entity().version(),

@@ -57,7 +57,7 @@

case sync_pb::LoopbackServerEntity_Type_BOOKMARK:

return PersistentBookmarkEntity::CreateFromEntity(entity.entity());

case sync_pb::LoopbackServerEntity_Type_UNIQUE:

- return PersistentUniqueClientEntity::CreateFromEntity(entity.entity());

+ return PersistentUniqueClientEntity::Create(entity.entity());

case sync_pb::LoopbackServerEntity_Type_UNKNOWN:

CHECK(false) << "Unknown type encountered";

return std::unique_ptr<LoopbackServerEntity>(nullptr);