chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc - Issue 2938553003: Revert of [sync] Replace FakeServer's implementation with LoopbackServer invocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc

Issue 2938553003: Revert of [sync] Replace FakeServer's implementation with LoopbackServer invocations. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc ('k') | chrome/browser/sync/test/integration/single_client_password_manager_setting_migrator_service_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc b/chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc

index cda11f36fa43bac510b7cc7c8b39264727bd4872..1145f217f1ea64561c4a97d88722f4f04301b77e 100644

--- a/chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc

+++ b/chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc

@@ -8,7 +8,7 @@

#include "chrome/browser/sync/test/integration/sync_test.h"

#include "chrome/browser/sync/test/integration/updated_progress_marker_checker.h"

#include "components/browser_sync/profile_sync_service.h"

-#include "components/sync/test/fake_server/fake_server.h"

+#include "components/sync/test/fake_server/tombstone_entity.h"

using extensions_helper::AllProfilesHaveSameExtensionsAsVerifier;

using extensions_helper::DisableExtension;

@@ -78,8 +78,8 @@

std::vector<sync_pb::SyncEntity> server_extensions =

GetFakeServer()->GetSyncEntitiesByModelType(syncer::EXTENSIONS);

ASSERT_EQ(1ul, server_extensions.size());

- std::unique_ptr<syncer::LoopbackServerEntity> tombstone(

- syncer::PersistentTombstoneEntity::CreateNew(

+ std::unique_ptr<fake_server::FakeServerEntity> tombstone(

+ fake_server::TombstoneEntity::Create(

server_extensions[0].id_string(),

server_extensions[0].client_defined_unique_tag()));

GetFakeServer()->InjectEntity(std::move(tombstone));