GeometryInterface: Enable GeometryInterfaces by default.

GeometryInterface: Enable GeometryInterfaces by default.

This patch includes the following things:
  - Make WebKitCSSMatrix an alias of DOMMatrix (Reland the revert patch[1])
  - Enable GeometryInterfaces by default (DOMMatrix, DOMPoint, DOMRect, DOMQuad)
  - Remove unnecessary runtime flag in CSSMatrixComponent.idl.

[1] Reverted patch: https://codereview.chromium.org/2943213002

Intent to ship:
  https://groups.google.com/a/chromium.org/d/msg/blink-dev/cAiTOdSGyes/Su7dlx32EQAJ

BUG=388780
Review-Url: https://codereview.chromium.org/2938413005
Cr-Commit-Position: refs/heads/master@{#481096}
Committed: https://chromium.googlesource.com/chromium/src/+/06592e080fd1cf4a188265ed4f9bcf826952671a

[zino, 2017-06-16 23:42:16]

Description was changed from

==========
Geometry: Enable GeometryInterfaces by default.

In three years, we have been able to ship this feature finally!

Intent to ship:
 
https://groups.google.com/a/chromium.org/d/msg/blink-dev/cAiTOdSGyes/Su7dlx32...

BUG=388780
==========

to

==========
Geometry: Enable GeometryInterfaces by default.

In three years, we have been able to ship this feature finally!

Intent to ship:
 
https://groups.google.com/a/chromium.org/d/msg/blink-dev/cAiTOdSGyes/Su7dlx32...

BUG=388780
==========

[zino, 2017-06-16 23:42:42]

jinho.bang@samsung.com changed reviewers:
+ foolip@chromium.org

[zino, 2017-06-16 23:48:27]

foolip@,

PTAL

I think this is urgent because the WebKitCSSMatrix doesn't work well currently
without this patch.

[zino, 2017-06-17 06:32:15]

Description was changed from

==========
Geometry: Enable GeometryInterfaces by default.

In three years, we have been able to ship this feature finally!

Intent to ship:
 
https://groups.google.com/a/chromium.org/d/msg/blink-dev/cAiTOdSGyes/Su7dlx32...

BUG=388780
==========

to

==========
GeometryInterface: Enable GeometryInterfaces by default.

This patch includes the following things:
  - Make WebKitCSSMatrix an alias of DOMMatrix (Reland the revert patch[1])
  - Enable GeometryInterfaces by default (DOMMatrix, DOMPoint, DOMRect, DOMQuad)
  - Remove unnecessary runtime flag in CSSMatrixComponent.idl.

[1] Reverted patch: https://codereview.chromium.org/2943213002

Intent to ship:
 
https://groups.google.com/a/chromium.org/d/msg/blink-dev/cAiTOdSGyes/Su7dlx32...

BUG=388780
==========

[zino, 2017-06-17 06:35:45]

jinho.bang@samsung.com changed reviewers:
+ fserb@chromium.org, timvolodine@chromium.org

[zino, 2017-06-17 06:35:46]

+timvolodine@ for android_webview.

PTAL

[zino, 2017-06-17 06:42:36]

foolip@ and others,

PTAL

I reverted the WebKitCSSMatrix alias patch[1] becuase it breaks existing web.
Without enabling experimental runtime flag, it didn't work.
For example,
  var matrix = new WebKitCSSMatrix();
  matrix.inverse(); <-- // TypeError occurs because the inverse() is not
exposed.

So, I'm trying to reland the patch here (including shipping GeometryInterfaces).

[1] https://codereview.chromium.org/2709763004/

Thank you.

[foolip, 2017-06-19 11:46:59]

lgtm % nit

https://codereview.chromium.org/2938413005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl (left):

https://codereview.chromium.org/2938413005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl:13:
RuntimeEnabled=GeometryInterfaces,
Why was this removed? I'm fine with removing the REF entirely, but as long as it
exists then bits like this should be retained.

[timvolodine, 2017-06-19 12:56:23]

On 2017/06/17 06:35:46, zino wrote:
> +timvolodine@ for android_webview.
> 
> PTAL

android_webview/.. -- lgtm

[zino, 2017-06-19 16:32:52]

Thank you for review. I left a comment.

https://codereview.chromium.org/2938413005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl (left):

https://codereview.chromium.org/2938413005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl:13:
RuntimeEnabled=GeometryInterfaces,
On 2017/06/19 11:46:59, foolip wrote:
> Why was this removed? I'm fine with removing the REF entirely, but as long as
it
> exists then bits like this should be retained.

The CSSMatrixComponent had two runtime flags CSSTypedOM and GeometryInterfaces
for its constructor before this patch. BTW, The CSSTypedOM was still under
experimental flag but it could be exposed due to another one GeometryInterface
flag.

I guess that the flag have been added because the constructor of
CSSMatrixComponent takes DOMMatrixReadOnly.
But it's not correct I think. Even if we enable GeometryInterfaces, the
CSSMatrixComponent should still be behind its runtime flag.
So, I removed it. :)

[zino, 2017-06-19 16:33:15]

jinho.bang@samsung.com changed reviewers:
+ dpranke@chromium.org

[zino, 2017-06-19 16:33:42]

+Dirk Pranke for SmokeTests

PTAL

[Dirk Pranke, 2017-06-19 21:46:00]

lgtm

[zino, 2017-06-19 23:01:03]

On 2017/06/19 16:32:52, zino wrote:
> Thank you for review. I left a comment.
> 
>
https://codereview.chromium.org/2938413005/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl (left):
> 
>
https://codereview.chromium.org/2938413005/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl:13:
> RuntimeEnabled=GeometryInterfaces,
> On 2017/06/19 11:46:59, foolip wrote:
> > Why was this removed? I'm fine with removing the REF entirely, but as long
as
> it
> > exists then bits like this should be retained.
> 
> The CSSMatrixComponent had two runtime flags CSSTypedOM and GeometryInterfaces
> for its constructor before this patch. BTW, The CSSTypedOM was still under
> experimental flag but it could be exposed due to another one GeometryInterface
> flag.
> 
> I guess that the flag have been added because the constructor of
> CSSMatrixComponent takes DOMMatrixReadOnly.
> But it's not correct I think. Even if we enable GeometryInterfaces, the
> CSSMatrixComponent should still be behind its runtime flag.
> So, I removed it. :)

foolip@, does it make sense?
If you agree with as-is, I'd like to push this patch. :-)

[foolip, 2017-06-20 08:07:54]

On 2017/06/19 23:01:03, zino wrote:
> On 2017/06/19 16:32:52, zino wrote:
> > Thank you for review. I left a comment.
> > 
> >
>
https://codereview.chromium.org/2938413005/diff/20001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl (left):
> > 
> >
>
https://codereview.chromium.org/2938413005/diff/20001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl:13:
> > RuntimeEnabled=GeometryInterfaces,
> > On 2017/06/19 11:46:59, foolip wrote:
> > > Why was this removed? I'm fine with removing the REF entirely, but as long
> as
> > it
> > > exists then bits like this should be retained.
> > 
> > The CSSMatrixComponent had two runtime flags CSSTypedOM and
GeometryInterfaces
> > for its constructor before this patch. BTW, The CSSTypedOM was still under
> > experimental flag but it could be exposed due to another one
GeometryInterface
> > flag.
> > 
> > I guess that the flag have been added because the constructor of
> > CSSMatrixComponent takes DOMMatrixReadOnly.
> > But it's not correct I think. Even if we enable GeometryInterfaces, the
> > CSSMatrixComponent should still be behind its runtime flag.
> > So, I removed it. :)
> 
> foolip@, does it make sense?
> If you agree with as-is, I'd like to push this patch. :-)

Oh, OK. Carry on :)

[zino, 2017-06-20 08:08:53]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2017-06-20 08:09:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 08:11:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 08:11:07]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[zino, 2017-06-20 10:32:39]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-06-20 10:32:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, foolip@chromium.org, timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/2938413005/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-20 10:32:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 12:36:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 12:36:21]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[zino, 2017-06-20 12:53:56]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-06-20 12:53:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, foolip@chromium.org, timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/2938413005/#ps60001
(title: "fix bot error")

[commit-bot: I haz the power, 2017-06-20 12:54:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 15:06:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 15:06:08]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[zino, 2017-06-20 15:36:52]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-06-20 15:36:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, foolip@chromium.org, timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/2938413005/#ps100001
(title: "GeometryInterface: Enable GeometryInterfaces by default.")

[commit-bot: I haz the power, 2017-06-20 15:37:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 17:54:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 17:54:33]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[zino, 2017-06-20 22:51:31]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 22:52:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 23:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 23:05:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[zino, 2017-06-21 00:11:23]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 00:11:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 02:39:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 02:39:30]

Dry run: This issue passed the CQ dry run.

[zino, 2017-06-21 02:57:55]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-06-21 02:57:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, foolip@chromium.org, timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/2938413005/#ps120001
(title: "rebased")

[commit-bot: I haz the power, 2017-06-21 02:58:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 03:03:04]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1498013875416620,
"parent_rev": "dca011e454153e08602ead192cda84abc2946a64", "commit_rev":
"06592e080fd1cf4a188265ed4f9bcf826952671a"}

[commit-bot: I haz the power, 2017-06-21 03:03:17]

Description was changed from

==========
GeometryInterface: Enable GeometryInterfaces by default.

This patch includes the following things:
  - Make WebKitCSSMatrix an alias of DOMMatrix (Reland the revert patch[1])
  - Enable GeometryInterfaces by default (DOMMatrix, DOMPoint, DOMRect, DOMQuad)
  - Remove unnecessary runtime flag in CSSMatrixComponent.idl.

[1] Reverted patch: https://codereview.chromium.org/2943213002

Intent to ship:
 
https://groups.google.com/a/chromium.org/d/msg/blink-dev/cAiTOdSGyes/Su7dlx32...

BUG=388780
==========

to

==========
GeometryInterface: Enable GeometryInterfaces by default.

This patch includes the following things:
  - Make WebKitCSSMatrix an alias of DOMMatrix (Reland the revert patch[1])
  - Enable GeometryInterfaces by default (DOMMatrix, DOMPoint, DOMRect, DOMQuad)
  - Remove unnecessary runtime flag in CSSMatrixComponent.idl.

[1] Reverted patch: https://codereview.chromium.org/2943213002

Intent to ship:
 
https://groups.google.com/a/chromium.org/d/msg/blink-dev/cAiTOdSGyes/Su7dlx32...

BUG=388780

Review-Url: https://codereview.chromium.org/2938413005
Cr-Commit-Position: refs/heads/master@{#481096}
Committed:
https://chromium.googlesource.com/chromium/src/+/06592e080fd1cf4a188265ed4f9b...
==========

[commit-bot: I haz the power, 2017-06-21 03:03:19]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/06592e080fd1cf4a188265ed4f9b...