third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl - Issue 2938413005: GeometryInterface: Enable GeometryInterfaces by default.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl

Issue 2938413005: GeometryInterface: Enable GeometryInterfaces by default. (Closed)

Patch Set: Merge WebKitCSSMatrix change Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5	5

6 // Represents a matrix value in a CSSTransformValue used for properties like	6 // Represents a matrix value in a CSSTransformValue used for properties like

7 // "transform".	7 // "transform".

8 // Spec: https://drafts.css-houdini.org/css-typed-om/#cssmatrixcomponent	8 // Spec: https://drafts.css-houdini.org/css-typed-om/#cssmatrixcomponent

9 [	9 [

10 Constructor(DOMMatrixReadOnly matrix),	10 Constructor(DOMMatrixReadOnly matrix),

11 Exposed=(Window,PaintWorklet),	11 Exposed=(Window,PaintWorklet),

12 RuntimeEnabled=CSSTypedOM,	12 RuntimeEnabled=CSSTypedOM,

13 RuntimeEnabled=GeometryInterfaces,
foolip 2017/06/19 11:46:59 Why was this removed? I'm fine with removing the R Why was this removed? I'm fine with removing the REF entirely, but as long as it exists then bits like this should be retained. zino 2017/06/19 16:32:52 The CSSMatrixComponent had two runtime flags CSSTy Show quoted text On 2017/06/19 11:46:59, foolip wrote: > Why was this removed? I'm fine with removing the REF entirely, but as long as it > exists then bits like this should be retained. The CSSMatrixComponent had two runtime flags CSSTypedOM and GeometryInterfaces for its constructor before this patch. BTW, The CSSTypedOM was still under experimental flag but it could be exposed due to another one GeometryInterface flag. I guess that the flag have been added because the constructor of CSSMatrixComponent takes DOMMatrixReadOnly. But it's not correct I think. Even if we enable GeometryInterfaces, the CSSMatrixComponent should still be behind its runtime flag. So, I removed it. :)
14 ] interface CSSMatrixComponent : CSSTransformComponent {	13 ] interface CSSMatrixComponent : CSSTransformComponent {

15 attribute DOMMatrix matrix;	14 attribute DOMMatrix matrix;

16 };	15 };

OLD	NEW

« no previous file with comments | « third_party/WebKit/Source/core/css/WebKitCSSMatrix.idl ('k') | third_party/WebKit/Source/core/frame/Window.idl » ('j') | no next file with comments »