Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2943213002: Revert of Make WebKitCSSMatrix an alias of DOMMatrix (Closed)

Created:
3 years, 6 months ago by zino
Modified:
3 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Hwanseung Lee, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make WebKitCSSMatrix an alias of DOMMatrix (patchset #16 id:300001 of https://codereview.chromium.org/2709763004/ ) Reason for revert: The WebKitCSSMatrix is not working after this change. Becuase the GeometryInterface is not shipped yet. Original issue's description: > Make WebkitCSSMatrix an alias of DOMMatrix > > DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple alias of it. > > Intent-to-ship Link : > https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/ > cAiTOdSGyes/Su7dlx32EQAJ > > BUG=581955 > > Review-Url: https://codereview.chromium.org/2709763004 > Cr-Commit-Position: refs/heads/master@{#479481} > Committed: https://chromium.googlesource.com/chromium/src/+/0ac2b97eb15689ba196f7f88b184b3a17f13d30d TBR=fserb@chromium.org,foolip@chromium.org,simonp@opera.com,timvolodine@chromium.org,dpranke@chromium.org,gogag2@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=581955 Review-Url: https://codereview.chromium.org/2943213002 Cr-Commit-Position: refs/heads/master@{#480276} Committed: https://chromium.googlesource.com/chromium/src/+/0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd

Patch Set 1 #

Patch Set 2 : Revert of Make WebKitCSSMatrix an alias of DOMMatrix (patchset #16 id:300001 of https://codereview.… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+742 lines, -169 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt View 1 2 chunks +10 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/SmokeTests View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/geometry-1/DOMMatrix-stringifier-expected.txt View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/geometry-1/WebKitCSSMatrix-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/custom-constructors-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/call-a-constructor-as-a-function-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +55 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +55 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/transforms/3d/general/cssmatrix-3d-zoom-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/transforms/cssmatrix-2d-interface.xhtml View 1 2 chunks +3 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/transforms/cssmatrix-2d-interface-expected.txt View 1 4 chunks +7 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/transforms/cssmatrix-3d-interface.xhtml View 1 1 chunk +2 lines, -38 lines 0 comments Download
M third_party/WebKit/LayoutTests/transforms/cssmatrix-3d-interface-expected.txt View 1 3 chunks +6 lines, -39 lines 0 comments Download
A third_party/WebKit/LayoutTests/transforms/cssmatrix-crash.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/transforms/cssmatrix-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 chunks +10 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +10 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/CSSMatrix.h View 1 chunk +171 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/CSSMatrix.cpp View 1 1 chunk +205 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/WebKitCSSMatrix.idl View 1 chunk +104 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Window.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
zino
Created Revert of Make WebKitCSSMatrix an alias of DOMMatrix
3 years, 6 months ago (2017-06-17 00:17:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943213002/1
3 years, 6 months ago (2017-06-17 00:18:28 UTC) #3
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-17 00:25:45 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/443863)
3 years, 6 months ago (2017-06-17 00:32:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943213002/440001
3 years, 6 months ago (2017-06-17 00:53:10 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-17 02:57:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:440001) as
https://chromium.googlesource.com/chromium/src/+/0b2fd946c81a4c7a26dcb6ed1c39...

Powered by Google App Engine
This is Rietveld 408576698