Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 2937663002: Sever isolate package's dependency on client/internal. (Closed)

Created:
3 years, 6 months ago by mcgreevy
Modified:
3 years, 6 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Sever isolate package's dependency on client/internal. This is in preparation for moving the isolate package to its own top-level directory, where it will not have access to client/internal. BUG=732677 Review-Url: https://codereview.chromium.org/2937663002 Committed: https://github.com/luci/luci-go/commit/d52b666028d0e37b9b33eb6bd73d1938a3cd3fff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M client/isolate/format.go View 5 chunks +4 lines, -5 lines 0 comments Download
M client/isolate/format_test.go View 5 chunks +4 lines, -5 lines 0 comments Download
M client/isolate/isolate.go View 4 chunks +5 lines, -5 lines 0 comments Download
M client/isolate/isolate_test.go View 7 chunks +7 lines, -7 lines 0 comments Download
M client/isolate/utils.go View 2 chunks +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
mcgreevy
@tansell: please review.
3 years, 6 months ago (2017-06-13 04:59:41 UTC) #2
mithro
You should add a bug in the CL description. Otherwise LGTM.
3 years, 6 months ago (2017-06-13 05:45:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937663002/1
3 years, 6 months ago (2017-06-13 05:51:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Win Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/36b8d395e0263010)
3 years, 6 months ago (2017-06-13 05:58:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937663002/1
3 years, 6 months ago (2017-06-15 03:38:49 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 03:47:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/d52b666028d0e37b9b33eb6bd73d1938a3cd3fff

Powered by Google App Engine
This is Rietveld 408576698