Sever isolate package's dependency on client/internal.

client/isolate/isolate.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package isolate
 
 import (
         "bytes"
         "encoding/json"
         "errors"
         "io/ioutil"
         "log"
         "os"
         "path/filepath"
         "regexp"
         "sort"
         "strings"
 
         "github.com/luci/luci-go/client/archiver"
-        "github.com/luci/luci-go/client/internal/common"
+        "github.com/luci/luci-go/common/flag/stringlistflag"
         "github.com/luci/luci-go/common/flag/stringmapflag"
         "github.com/luci/luci-go/common/isolated"
         "github.com/luci/luci-go/common/isolatedclient"
         "github.com/luci/luci-go/common/runtime/tracer"
 )
 
 // IsolatedGenJSONVersion is used in the batcharchive json format.
 //
 // TODO(tandrii): Migrate to batch_archive.go.
 const IsolatedGenJSONVersion = 1
@@ skipping 12 matching lines @@
 // Tree to be isolated.
 type Tree struct {
         Cwd  string
         Opts ArchiveOptions
 }
 
 // ArchiveOptions for achiving trees.
 type ArchiveOptions struct {
         Isolate         string              `json:"isolate"`
         Isolated        string              `json:"isolated"`
-        Blacklist       common.Strings      `json:"blacklist"`
+        Blacklist       stringlistflag.Flag `json:"blacklist"`
         PathVariables   stringmapflag.Value `json:"path_variables"`
         ExtraVariables  stringmapflag.Value `json:"extra_variables"`
         ConfigVariables stringmapflag.Value `json:"config_variables"`
 }
 
 // Init initializes with non-nil values.
 func (a *ArchiveOptions) Init() {
-        a.Blacklist = common.Strings{}
+        a.Blacklist = stringlistflag.Flag{}
         a.PathVariables = map[string]string{}
-        if common.IsWindows() {
+        if IsWindows() {
                 a.PathVariables["EXECUTABLE_SUFFIX"] = ".exe"
         } else {
                 a.PathVariables["EXECUTABLE_SUFFIX"] = ""
         }
         a.ExtraVariables = map[string]string{}
         a.ConfigVariables = map[string]string{}
 }
 
 // PostProcess post-processes the flags to fix any compatibility issue.
 func (a *ArchiveOptions) PostProcess(cwd string) {
         // Set default blacklist only if none is set.
         if len(a.Blacklist) == 0 {
                 // This cannot be generalized as ".*" as there is known use that require
                 // a ".pki" directory to be mapped.
-                a.Blacklist = common.Strings{
+                a.Blacklist = stringlistflag.Flag{
                         // Temporary python files.
                         "*.pyc",
                         // Temporary vim files.
                         "*.swp",
                         ".git",
                         ".hg",
                         ".svn",
                 }
         }
         if !filepath.IsAbs(a.Isolate) {
@@ skipping 230 matching lines @@
         raw := &bytes.Buffer{}
         if err = json.NewEncoder(raw).Encode(i); err != nil {
                 return nil, err
         }
 
         if err := ioutil.WriteFile(opts.Isolated, raw.Bytes(), 0644); err != nil {
                 return nil, err
         }
         return arch.Push(displayName, isolatedclient.NewBytesSource(raw.Bytes()), 0), nil
 }