Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2936713003: Sever isolate cmd dependency on Canceler. (Closed)

Created:
3 years, 6 months ago by mcgreevy
Modified:
3 years, 6 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M client/cmd/isolate/archive.go View 4 chunks +18 lines, -2 lines 0 comments Download
M client/cmd/isolate/batch_archive.go View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
mcgreevy
3 years, 6 months ago (2017-06-13 05:53:27 UTC) #2
mithro
LGTM. I don't like the word Sever here as it took me a couple of ...
3 years, 6 months ago (2017-06-13 06:37:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936713003/1
3 years, 6 months ago (2017-06-15 03:49:19 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 03:55:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/2bf17973b3ef98d40feda9e113bcb8c6607b479b

Powered by Google App Engine
This is Rietveld 408576698