Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2937493002: [ObjC ARC] Converts components/sessions:unit_tests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts components/sessions:unit_tests to ARC. "ARC" is Automatic Reference Counting, a memory management model for Objective-C. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2937493002 Cr-Commit-Position: refs/heads/master@{#479648} Committed: https://chromium.googlesource.com/chromium/src/+/eabc5221db21a5f0036a7eed24db496187aa8e90

Patch Set 1 #

Patch Set 2 : fix BUILD.gn #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M components/sessions/BUILD.gn View 1 1 chunk +3 lines, -0 lines 2 comments Download
M components/sessions/ios/ios_serialized_navigation_builder_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-12 20:11:19 UTC) #10
Mr4D (OOO till 08-26)
https://codereview.chromium.org/2937493002/diff/20001/components/sessions/BUILD.gn File components/sessions/BUILD.gn (right): https://codereview.chromium.org/2937493002/diff/20001/components/sessions/BUILD.gn#newcode163 components/sessions/BUILD.gn:163: configs += [ "//build/config/compiler:enable_arc" ] I am confused now: ...
3 years, 6 months ago (2017-06-12 21:13:32 UTC) #12
marq (ping after 24h)
On 2017/06/12 21:13:32, Mr4D wrote: > https://codereview.chromium.org/2937493002/diff/20001/components/sessions/BUILD.gn > File components/sessions/BUILD.gn (right): > > https://codereview.chromium.org/2937493002/diff/20001/components/sessions/BUILD.gn#newcode163 > ...
3 years, 6 months ago (2017-06-12 21:53:55 UTC) #13
stkhapugin
ARC lgtm https://codereview.chromium.org/2937493002/diff/20001/components/sessions/BUILD.gn File components/sessions/BUILD.gn (right): https://codereview.chromium.org/2937493002/diff/20001/components/sessions/BUILD.gn#newcode170 components/sessions/BUILD.gn:170: "ios/ios_serialized_navigation_builder_unittest.mm", Maybe we should move this test ...
3 years, 6 months ago (2017-06-13 12:09:58 UTC) #15
Mr4D (OOO till 08-26)
Thanks for explaining! Sorry for delay, but was travelling and got swamped once I was ...
3 years, 6 months ago (2017-06-14 07:06:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937493002/20001
3 years, 6 months ago (2017-06-15 07:56:23 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 09:37:49 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eabc5221db21a5f0036a7eed24db...

Powered by Google App Engine
This is Rietveld 408576698