|
|
Created:
3 years, 6 months ago by marq (ping after 24h) Modified:
3 years, 6 months ago CC:
chromium-reviews, ios-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[ObjC ARC] Converts components/sessions:unit_tests to ARC.
"ARC" is Automatic Reference Counting, a memory management model for Objective-C.
Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
Review-Url: https://codereview.chromium.org/2937493002
Cr-Commit-Position: refs/heads/master@{#479648}
Committed: https://chromium.googlesource.com/chromium/src/+/eabc5221db21a5f0036a7eed24db496187aa8e90
Patch Set 1 #Patch Set 2 : fix BUILD.gn #
Total comments: 2
Messages
Total messages: 21 (14 generated)
The CQ bit was checked by marq@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by marq@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
marq@chromium.org changed reviewers: + skuhne@google.com, stkhapugin@chromium.org
skuhne@chromium.org changed reviewers: + skuhne@chromium.org
https://codereview.chromium.org/2937493002/diff/20001/components/sessions/BUI... File components/sessions/BUILD.gn (right): https://codereview.chromium.org/2937493002/diff/20001/components/sessions/BUI... components/sessions/BUILD.gn:163: configs += [ "//build/config/compiler:enable_arc" ] I am confused now: Do we want to allow ARC for iOS? How does that work?
On 2017/06/12 21:13:32, Mr4D wrote: > https://codereview.chromium.org/2937493002/diff/20001/components/sessions/BUI... > File components/sessions/BUILD.gn (right): > > https://codereview.chromium.org/2937493002/diff/20001/components/sessions/BUI... > components/sessions/BUILD.gn:163: configs += [ > "//build/config/compiler:enable_arc" ] > I am confused now: Do we want to allow ARC for iOS? How does that work? Yes, this CL is one of many gradually enabling ARC for iOS build targets. In some cases, such as this one, there are no code changes needed; in others (such as https://codereview.chromium.org/2936583002/), there are considerable changes.
Description was changed from ========== [ObjC ARC] Converts components/sessions:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts components/sessions:unit_tests to ARC. "ARC" is Automatic Reference Counting, a memory management model for Objective-C. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ==========
ARC lgtm https://codereview.chromium.org/2937493002/diff/20001/components/sessions/BUI... File components/sessions/BUILD.gn (right): https://codereview.chromium.org/2937493002/diff/20001/components/sessions/BUI... components/sessions/BUILD.gn:170: "ios/ios_serialized_navigation_builder_unittest.mm", Maybe we should move this test to a new target, unit_tests_ios or ios:unit_tests, instead of conditional flag flipping?
Thanks for explaining! Sorry for delay, but was travelling and got swamped once I was back. lgtm
The CQ bit was checked by marq@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497513373729780, "parent_rev": "a29852561db344c76621a33bb23ce9108ba24a4b", "commit_rev": "eabc5221db21a5f0036a7eed24db496187aa8e90"}
Message was sent while issue was closed.
Description was changed from ========== [ObjC ARC] Converts components/sessions:unit_tests to ARC. "ARC" is Automatic Reference Counting, a memory management model for Objective-C. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts components/sessions:unit_tests to ARC. "ARC" is Automatic Reference Counting, a memory management model for Objective-C. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2937493002 Cr-Commit-Position: refs/heads/master@{#479648} Committed: https://chromium.googlesource.com/chromium/src/+/eabc5221db21a5f0036a7eed24db... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/eabc5221db21a5f0036a7eed24db... |