Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2936583002: [ObjC ARC] Converts ios/chrome/browser/ui/authentication:authentication to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin, msarda
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/authentication:authentication to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2936583002 Cr-Commit-Position: refs/heads/master@{#479055} Committed: https://chromium.googlesource.com/chromium/src/+/191766192510fe8eae7d3197a19ce1a42656e3cd

Patch Set 1 #

Total comments: 8

Patch Set 2 : Review feedback. #

Total comments: 4

Patch Set 3 : Review fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -329 lines) Patch
M ios/chrome/browser/signin/chrome_identity_service_observer_bridge.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/authentication/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/authentication/authentication_flow.mm View 1 2 13 chunks +29 lines, -32 lines 0 comments Download
M ios/chrome/browser/ui/authentication/authentication_flow_performer.mm View 14 chunks +53 lines, -57 lines 0 comments Download
M ios/chrome/browser/ui/authentication/authentication_ui_util.mm View 2 chunks +8 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/authentication/chrome_signin_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm View 1 21 chunks +61 lines, -69 lines 0 comments Download
M ios/chrome/browser/ui/authentication/re_signin_infobar_delegate.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm View 13 chunks +48 lines, -48 lines 0 comments Download
M ios/chrome/browser/ui/authentication/signin_account_selector_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/authentication/signin_account_selector_view_controller.mm View 10 chunks +28 lines, -30 lines 0 comments Download
M ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.mm View 1 11 chunks +41 lines, -43 lines 0 comments Download
M ios/chrome/browser/ui/authentication/signin_interaction_controller.mm View 1 15 chunks +44 lines, -40 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-12 12:21:16 UTC) #4
msarda
https://codereview.chromium.org/2936583002/diff/1/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm File ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm (right): https://codereview.chromium.org/2936583002/diff/1/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm#newcode295 ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm:295: - (void)setDelegate:(id<ChromeSigninViewControllerDelegate>)delegate { I think this setDelegate method can ...
3 years, 6 months ago (2017-06-12 12:49:13 UTC) #5
marq (ping after 24h)
Thanks, PTAL https://codereview.chromium.org/2936583002/diff/1/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm File ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm (right): https://codereview.chromium.org/2936583002/diff/1/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm#newcode295 ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm:295: - (void)setDelegate:(id<ChromeSigninViewControllerDelegate>)delegate { On 2017/06/12 12:49:13, msarda ...
3 years, 6 months ago (2017-06-12 14:20:40 UTC) #9
stkhapugin
lgtm with comment https://codereview.chromium.org/2936583002/diff/20001/ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm File ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm (left): https://codereview.chromium.org/2936583002/diff/20001/ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm#oldcode15 ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm:15: #include "ios/chrome/browser/signin/chrome_identity_service_observer_bridge.h" This header needs an ...
3 years, 6 months ago (2017-06-13 11:58:03 UTC) #13
msarda
LGTM with a comment. Please address before landing the CL. https://codereview.chromium.org/2936583002/diff/20001/ios/chrome/browser/ui/authentication/authentication_flow.mm File ios/chrome/browser/ui/authentication/authentication_flow.mm (right): https://codereview.chromium.org/2936583002/diff/20001/ios/chrome/browser/ui/authentication/authentication_flow.mm#newcode134 ...
3 years, 6 months ago (2017-06-13 13:04:53 UTC) #14
marq (ping after 24h)
Thanks for the careful reviews! https://codereview.chromium.org/2936583002/diff/20001/ios/chrome/browser/ui/authentication/authentication_flow.mm File ios/chrome/browser/ui/authentication/authentication_flow.mm (right): https://codereview.chromium.org/2936583002/diff/20001/ios/chrome/browser/ui/authentication/authentication_flow.mm#newcode134 ios/chrome/browser/ui/authentication/authentication_flow.mm:134: _signInCompletion = completion; On ...
3 years, 6 months ago (2017-06-13 13:55:10 UTC) #15
marq (ping after 24h)
Review fixes.
3 years, 6 months ago (2017-06-13 13:56:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936583002/40001
3 years, 6 months ago (2017-06-13 13:56:29 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 17:07:24 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/191766192510fe8eae7d3197a19c...

Powered by Google App Engine
This is Rietveld 408576698