Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: components/sessions/BUILD.gn

Issue 2937493002: [ObjC ARC] Converts components/sessions:unit_tests to ARC. (Closed)
Patch Set: fix BUILD.gn Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/sessions/ios/ios_serialized_navigation_builder_unittest.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 } 7 }
8 8
9 config("implementation") { 9 config("implementation") {
10 defines = [ "SESSIONS_IMPLEMENTATION" ] 10 defines = [ "SESSIONS_IMPLEMENTATION" ]
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 152
153 if (!is_android && !is_ios) { 153 if (!is_android && !is_ios) {
154 sources += [ 154 sources += [
155 "core/base_session_service_test_helper.cc", 155 "core/base_session_service_test_helper.cc",
156 "core/base_session_service_test_helper.h", 156 "core/base_session_service_test_helper.h",
157 ] 157 ]
158 } 158 }
159 } 159 }
160 160
161 source_set("unit_tests") { 161 source_set("unit_tests") {
162 if (is_ios) {
163 configs += [ "//build/config/compiler:enable_arc" ]
Mr4D (OOO till 08-26) 2017/06/12 21:13:32 I am confused now: Do we want to allow ARC for iOS
164 }
162 testonly = true 165 testonly = true
163 sources = [ 166 sources = [
164 "core/serialized_navigation_entry_unittest.cc", 167 "core/serialized_navigation_entry_unittest.cc",
165 "core/session_backend_unittest.cc", 168 "core/session_backend_unittest.cc",
166 "core/session_types_unittest.cc", 169 "core/session_types_unittest.cc",
167 "ios/ios_serialized_navigation_builder_unittest.mm", 170 "ios/ios_serialized_navigation_builder_unittest.mm",
stkhapugin 2017/06/13 12:09:58 Maybe we should move this test to a new target, un
168 "ios/ios_serialized_navigation_driver_unittest.cc", 171 "ios/ios_serialized_navigation_driver_unittest.cc",
169 ] 172 ]
170 173
171 if (!is_ios) { 174 if (!is_ios) {
172 sources += [ 175 sources += [
173 "content/content_serialized_navigation_builder_unittest.cc", 176 "content/content_serialized_navigation_builder_unittest.cc",
174 "content/content_serialized_navigation_driver_unittest.cc", 177 "content/content_serialized_navigation_driver_unittest.cc",
175 ] 178 ]
176 } 179 }
177 180
178 public_deps = [ 181 public_deps = [
179 ":sessions", 182 ":sessions",
180 ] 183 ]
181 184
182 deps = [ 185 deps = [
183 ":test_support", 186 ":test_support",
184 "//base/test:test_support", 187 "//base/test:test_support",
185 "//components/sync", 188 "//components/sync",
186 "//testing/gtest", 189 "//testing/gtest",
187 "//ui/base", # For page transition types. 190 "//ui/base", # For page transition types.
188 "//url", 191 "//url",
189 ] 192 ]
190 193
191 if (!is_ios) { 194 if (!is_ios) {
192 deps += [ "//content/public/common" ] 195 deps += [ "//content/public/common" ]
193 } 196 }
194 } 197 }
OLDNEW
« no previous file with comments | « no previous file | components/sessions/ios/ios_serialized_navigation_builder_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698