Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSTranslation.h

Issue 2937383002: [CSS Typed OM] Add missing error handling in the CSSTranslation constructor (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSTranslation.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h b/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h
index 9e54dea76b0e564f5ad843c6bf0ffa22e07fa531..d97d4d97aee35f850dab0cedb4c27c4dc84e7366 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h
@@ -22,15 +22,15 @@ class CORE_EXPORT CSSTranslation final : public CSSTransformComponent {
public:
// Constructors defined in the IDL.
- static CSSTranslation* Create(CSSNumericValue* x,
- CSSNumericValue* y,
- ExceptionState&) {
- return new CSSTranslation(x, y, nullptr);
- }
static CSSTranslation* Create(CSSNumericValue* x,
CSSNumericValue* y,
CSSNumericValue* z,
ExceptionState&);
+ static CSSTranslation* Create(CSSNumericValue* x,
+ CSSNumericValue* y,
+ ExceptionState& exception_state) {
+ return Create(x, y, nullptr, exception_state);
+ }
// Blink-internal ways of creating CSSTranslations.
static CSSTranslation* FromCSSValue(const CSSFunctionValue& value) {

Powered by Google App Engine
This is Rietveld 408576698