Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2937253003: cros: Replace BrowserThread::FILE in InputServiceProxy (Closed)

Created:
3 years, 6 months ago by xiyuan
Modified:
3 years, 6 months ago
Reviewers:
achuithb, fdoray
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Replace BrowserThread::FILE in InputServiceProxy BrowserThread::FILE is deprecated in favor of the post_task API. BUG=689520 Review-Url: https://codereview.chromium.org/2937253003 Cr-Commit-Position: refs/heads/master@{#481228} Committed: https://chromium.googlesource.com/chromium/src/+/164abed19ba6d4882dc3b66028bcbfd24399b177

Patch Set 1 #

Total comments: 4

Patch Set 2 : update dependent code to fix tests #

Total comments: 11

Patch Set 3 : for #2 #

Total comments: 16

Patch Set 4 : for #3 #

Patch Set 5 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -108 lines) Patch
M chrome/browser/chromeos/device/input_service_proxy.h View 1 2 3 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/device/input_service_proxy.cc View 1 2 3 3 chunks +69 lines, -50 lines 1 comment Download
M chrome/browser/chromeos/device/input_service_test_helper.cc View 1 2 3 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/hid_detection_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.h View 1 2 3 4 chunks +9 lines, -9 lines 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.cc View 1 2 3 14 chunks +20 lines, -22 lines 0 comments Download
M components/pairing/shark_connection_listener.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/pairing/shark_connection_listener.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 44 (29 generated)
xiyuan
Could you help to review this? Thanks.
3 years, 6 months ago (2017-06-15 22:50:16 UTC) #4
achuithb
LGTM. We have 63 instances of chromeos migrations in this doc: https://docs.google.com/spreadsheets/d/18x9PGMlfgWcBr4fDz2SEEtIwTpSjcBFT2Puib47ZF1w/edit I'm wondering if ...
3 years, 6 months ago (2017-06-15 23:04:59 UTC) #7
xiyuan
Filing separate bugs and assign to the team makes sense to me. I was just ...
3 years, 6 months ago (2017-06-16 19:21:28 UTC) #8
xiyuan
PTAL. Thanks.
3 years, 6 months ago (2017-06-19 15:01:53 UTC) #18
xiyuan
+fdoray, please review lazy_task_runner.h change. Thanks.
3 years, 6 months ago (2017-06-19 21:17:22 UTC) #20
achuithb
lgtm. Sorry you had to rewrite the code that generates a callback pointer via a ...
3 years, 6 months ago (2017-06-19 22:34:42 UTC) #21
xiyuan
https://codereview.chromium.org/2937253003/diff/60001/base/task_scheduler/lazy_task_runner.h File base/task_scheduler/lazy_task_runner.h (right): https://codereview.chromium.org/2937253003/diff/60001/base/task_scheduler/lazy_task_runner.h#newcode108 base/task_scheduler/lazy_task_runner.h:108: ALLOW_UNUSED_TYPE constexpr base::SingleThreadTaskRunnerThreadMode \ On 2017/06/19 22:34:42, achuithb wrote: ...
3 years, 6 months ago (2017-06-19 23:00:26 UTC) #22
achuithb
lgtm. Thanks for taking care of the comments! https://codereview.chromium.org/2937253003/diff/60001/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc File chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc (right): https://codereview.chromium.org/2937253003/diff/60001/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc#newcode70 chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc:70: InputServiceProxy::SetUseUIThreadForTesting(true); ...
3 years, 6 months ago (2017-06-20 08:36:48 UTC) #27
fdoray
https://codereview.chromium.org/2937253003/diff/80001/chrome/browser/chromeos/device/input_service_proxy.cc File chrome/browser/chromeos/device/input_service_proxy.cc (right): https://codereview.chromium.org/2937253003/diff/80001/chrome/browser/chromeos/device/input_service_proxy.cc#newcode111 chrome/browser/chromeos/device/input_service_proxy.cc:111: FROM_HERE, base::Bind(&InputServiceProxy::ServiceObserver::Initialize, PostTask() takes a OnceClosure as argument https://chromium.googlesource.com/chromium/src/+/b30e6bf3abc9c86a5fdfa612bdf0c24788e6fc91/base/task_runner.h#64. ...
3 years, 6 months ago (2017-06-20 12:42:39 UTC) #28
xiyuan
https://codereview.chromium.org/2937253003/diff/80001/chrome/browser/chromeos/device/input_service_proxy.cc File chrome/browser/chromeos/device/input_service_proxy.cc (right): https://codereview.chromium.org/2937253003/diff/80001/chrome/browser/chromeos/device/input_service_proxy.cc#newcode111 chrome/browser/chromeos/device/input_service_proxy.cc:111: FROM_HERE, base::Bind(&InputServiceProxy::ServiceObserver::Initialize, On 2017/06/20 12:42:39, fdoray wrote: > PostTask() ...
3 years, 6 months ago (2017-06-20 15:26:55 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937253003/120001
3 years, 6 months ago (2017-06-21 15:49:13 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/411808)
3 years, 6 months ago (2017-06-21 16:23:02 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937253003/120001
3 years, 6 months ago (2017-06-21 16:40:06 UTC) #40
commit-bot: I haz the power
Committed patchset #5 (id:120001) as https://chromium.googlesource.com/chromium/src/+/164abed19ba6d4882dc3b66028bcbfd24399b177
3 years, 6 months ago (2017-06-21 17:18:51 UTC) #43
fdoray
3 years, 6 months ago (2017-06-22 12:27:44 UTC) #44
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2937253003/diff/120001/chrome/browser/chromeo...
File chrome/browser/chromeos/device/input_service_proxy.cc (right):

https://codereview.chromium.org/2937253003/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/device/input_service_proxy.cc:27: // are updated to
check on sequence instead of thread.
Create bug to make InputServiceLinux and friends sequence-friendly. Add TODO and
reference to bug here.

Powered by Google App Engine
This is Rietveld 408576698