cros: Replace BrowserThread::FILE in InputServiceProxy

chrome/browser/chromeos/device/input_service_proxy.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_DEVICE_INPUT_SERVICE_PROXY_H_
 #define CHROME_BROWSER_CHROMEOS_DEVICE_INPUT_SERVICE_PROXY_H_
 
 #include <memory>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/observer_list.h"
 #include "base/task_runner.h"
 #include "base/threading/thread_checker.h"
-#include "content/public/browser/browser_thread.h"
 #include "device/hid/input_service_linux.h"
 
 namespace chromeos {
 
 // Proxy to device::InputServiceLinux. Should be created and used on the UI
 // thread.
 class InputServiceProxy {
  public:
   typedef device::InputServiceLinux::InputDeviceInfo InputDeviceInfo;
 
@@ skipping 12 matching lines @@
   InputServiceProxy();
   ~InputServiceProxy();
 
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   void GetDevices(const GetDevicesCallback& callback);
   void GetDeviceInfo(const std::string& id,
                      const GetDeviceInfoCallback& callback);
 
   // Should be called once before any InputServiceProxy instance is created.

[achuithb, 2017/06/15 23:04:59]

Should we move this comment after the using declaration?

[xiyuan, 2017/06/16 19:21:27]

will do

-  static void SetThreadIdForTesting(content::BrowserThread::ID thread_id);
+  using TaskRunnerFactory =
+      base::Callback<scoped_refptr<base::TaskRunner>(void)>;

[achuithb, 2017/06/15 23:04:59]

I'm curious if this is the standard pattern now for switching between UI and
background threads? It's a bit tricky with pointers to callbacks that bind
lambda's.

[xiyuan, 2017/06/16 19:21:27]

Not a standard pattern. I used this because it fits in with the current test
code. I could also make it a boolean though since there are only two tests use
this and both want UI thread.

+  static void SetTaskRunnerFactoryForTesting(TaskRunnerFactory* factory);
 
  private:
-  static content::BrowserThread::ID thread_identifier_;
-
   class ServiceObserver;
 
   void OnDeviceAdded(const device::InputServiceLinux::InputDeviceInfo& info);
   void OnDeviceRemoved(const std::string& id);
 
   base::ObserverList<Observer> observers_;
   std::unique_ptr<ServiceObserver> service_observer_;
 
   base::ThreadChecker thread_checker_;
 
   scoped_refptr<base::TaskRunner> task_runner_;
 
   base::WeakPtrFactory<InputServiceProxy> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(InputServiceProxy);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_DEVICE_INPUT_SERVICE_PROXY_H_