Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2946823002: Fix missing base:: in a couple of macros (Closed)

Created:
3 years, 6 months ago by xiyuan
Modified:
3 years, 6 months ago
Reviewers:
robliao, fdoray
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing base:: in a couple of macros LAZY_SINGLE_THREAD_TASK_RUNNER_INITIALIZER and LAZY_COM_STA_TASK_RUNNER_INITIALIZER should have base:: for SingleThreadTaskRunnerThreadMode. Otherwise, it would end up with compiler errors when expanded outside of base namespace. BUG=730170 Review-Url: https://codereview.chromium.org/2946823002 Cr-Commit-Position: refs/heads/master@{#480798} Committed: https://chromium.googlesource.com/chromium/src/+/a235270a716377add008305c9b9335d872bcba51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/task_scheduler/lazy_task_runner.h View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
xiyuan
Split from https://codereview.chromium.org/2937253003/ as suggested by the other reviewer. PATL. Thanks.
3 years, 6 months ago (2017-06-19 22:59:10 UTC) #3
robliao
lgtm
3 years, 6 months ago (2017-06-20 00:01:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946823002/1
3 years, 6 months ago (2017-06-20 12:16:00 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 13:02:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a235270a716377add008305c9b93...

Powered by Google App Engine
This is Rietveld 408576698