Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 2936833002: [ObjC ARC] Converts ios/chrome/browser/ui:unit_tests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2936833002 Cr-Commit-Position: refs/heads/master@{#479712} Committed: https://chromium.googlesource.com/chromium/src/+/309563011bbb50c1311bef5e9e99ad7319d0ee0e

Patch Set 1 #

Patch Set 2 : Fix bad ARC guard. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -169 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/browser_container_view_unittest.mm View 2 chunks +9 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller_unittest.mm View 1 19 chunks +51 lines, -51 lines 0 comments Download
M ios/chrome/browser/ui/chrome_web_view_factory_unittest.mm View 3 chunks +9 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/file_locations_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/fullscreen_controller_unittest.mm View 1 18 chunks +54 lines, -60 lines 0 comments Download
M ios/chrome/browser/ui/key_commands_provider_unittest.mm View 4 chunks +8 lines, -9 lines 0 comments Download
M ios/chrome/browser/ui/native_content_controller_unittest.mm View 1 chunk +17 lines, -14 lines 0 comments Download
M ios/chrome/browser/ui/network_activity_indicator_manager_unittest.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/open_in_controller_unittest.mm View 3 chunks +10 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/open_in_toolbar_unittest.mm View 2 chunks +8 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/page_not_available_controller_unittest.mm View 1 chunk +8 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/preload_controller_unittest.mm View 4 chunks +7 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/ui_util_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/uikit_ui_util_unittest.mm View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
marq (ping after 24h)
Fix bad ARC guard.
3 years, 6 months ago (2017-06-15 09:02:32 UTC) #9
marq (ping after 24h)
3 years, 6 months ago (2017-06-15 09:07:42 UTC) #13
stkhapugin
lgtm
3 years, 6 months ago (2017-06-15 15:32:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936833002/20001
3 years, 6 months ago (2017-06-15 15:32:57 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 15:38:09 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/309563011bbb50c1311bef5e9e99...

Powered by Google App Engine
This is Rietveld 408576698