Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: ios/chrome/browser/ui/chrome_web_view_factory_unittest.mm

Issue 2936833002: [ObjC ARC] Converts ios/chrome/browser/ui:unit_tests to ARC. (Closed)
Patch Set: Fix bad ARC guard. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/chrome_web_view_factory_unittest.mm
diff --git a/ios/chrome/browser/ui/chrome_web_view_factory_unittest.mm b/ios/chrome/browser/ui/chrome_web_view_factory_unittest.mm
index 92e7ede8765a6c1f55342e10c94f16b92c5e7f22..e285b13a9d6963945f91d0064d1fa8021451908c 100644
--- a/ios/chrome/browser/ui/chrome_web_view_factory_unittest.mm
+++ b/ios/chrome/browser/ui/chrome_web_view_factory_unittest.mm
@@ -4,7 +4,6 @@
#import "ios/chrome/browser/ui/chrome_web_view_factory.h"
-#include "base/mac/scoped_nsobject.h"
#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
@@ -20,6 +19,10 @@
#import "third_party/ocmock/OCMock/OCMock.h"
#import "third_party/ocmock/gtest_support.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
using web::RequestTrackerImpl;
namespace {
@@ -44,8 +47,11 @@ class ChromeWebViewFactoryTest : public PlatformTest {
TEST_F(ChromeWebViewFactoryTest, TestTrackerForExternal) {
[ChromeWebViewFactory setBrowserStateToUseForExternal:&chrome_browser_state_];
- base::scoped_nsobject<UIWebView> webView([ChromeWebViewFactory
- newExternalWebView:chrome_browser_state_.SharingService()]);
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-variable"
+ UIWebView* webView = [ChromeWebViewFactory
+ newExternalWebView:chrome_browser_state_.SharingService()];
+#pragma clang diagnostic pop
// Check that the tracker is registered
RequestTrackerImpl* tracker = RequestTrackerImpl::GetTrackerForRequestGroupID(
ChromeWebView::kExternalRequestGroupID);
« no previous file with comments | « ios/chrome/browser/ui/browser_view_controller_unittest.mm ('k') | ios/chrome/browser/ui/file_locations_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698