Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2936233004:
[subresource_filter] Use constexpr for subresource filter dev tools messages. (Closed)
|
Created:
3 years, 6 months ago by shivanisha Modified:
3 years, 6 months ago CC:
chromium-reviews, subresource-filter-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[subresource_filter] Use constexpr for subresource filter dev tools messages.
BUG=724549
Review-Url: https://codereview.chromium.org/2936233004
Cr-Commit-Position: refs/heads/master@{#480854}
Committed: https://chromium.googlesource.com/chromium/src/+/ecbe022c24e066b460128af99a5eca75ee9f1690
Patch Set 1 : Use constexpr #Patch Set 2 : Compile error fixed #Patch Set 3 : Compile error fixed #
Total comments: 1
Patch Set 4 : Added include sstream #
Messages
Total messages: 31 (23 generated)
The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
pasko@chromium.org changed reviewers: + pasko@chromium.org
non-owner lgtm, thank you
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run
Patchset #2 (id:40001) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
thestig@chromium.org changed reviewers: + thestig@chromium.org
Can we fix the compilation errors and land this CL?
On 2017/06/19 20:46:08, Lei Zhang wrote: > Can we fix the compilation errors and land this CL? shivanisha is OOO for much of this week. I can take over and land if this is P1/P0.
On 2017/06/19 21:06:55, on gerrit - ping aggressively wrote: > On 2017/06/19 20:46:08, Lei Zhang wrote: > > Can we fix the compilation errors and land this CL? > > shivanisha is OOO for much of this week. I can take over and land if this is > P1/P0. It's not P0/P1. It just looks like this CL is so close to finishing...
The CQ bit was checked by shivanisha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
shivanisha@chromium.org changed reviewers: + csharrison@chromium.org
csharrison@, PTAL, Thanks!
LGTM https://codereview.chromium.org/2936233004/diff/80001/chrome/browser/subresou... File chrome/browser/subresource_filter/subresource_filter_browsertest.cc (right): https://codereview.chromium.org/2936233004/diff/80001/chrome/browser/subresou... chrome/browser/subresource_filter/subresource_filter_browsertest.cc:547: std::ostringstream message_filter; #include <sstream>
The CQ bit was checked by shivanisha@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org, csharrison@chromium.org Link to the patchset: https://codereview.chromium.org/2936233004/#ps100001 (title: "Added include sstream")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1497972704006060,
"parent_rev": "4f1dec3a5a8600ab587761bb9f647cc5806297d5", "commit_rev":
"ecbe022c24e066b460128af99a5eca75ee9f1690"}
Message was sent while issue was closed.
Description was changed from ========== [subresource_filter] Use constexpr for subresource filter dev tools messages. BUG=724549 ========== to ========== [subresource_filter] Use constexpr for subresource filter dev tools messages. BUG=724549 Review-Url: https://codereview.chromium.org/2936233004 Cr-Commit-Position: refs/heads/master@{#480854} Committed: https://chromium.googlesource.com/chromium/src/+/ecbe022c24e066b460128af99a5e... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as https://chromium.googlesource.com/chromium/src/+/ecbe022c24e066b460128af99a5e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
