Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: components/subresource_filter/core/browser/subresource_filter_constants.cc

Issue 2936233004: [subresource_filter] Use constexpr for subresource filter dev tools messages. (Closed)
Patch Set: Added include sstream Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/subresource_filter/core/browser/subresource_filter_constants.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/subresource_filter/core/browser/subresource_filter_constants.cc
diff --git a/components/subresource_filter/core/browser/subresource_filter_constants.cc b/components/subresource_filter/core/browser/subresource_filter_constants.cc
index fc3aaba8ab932f831f12a5425e2bc358888d3ced..dbc9e0999c042c38fdf1126649024035fbd2860e 100644
--- a/components/subresource_filter/core/browser/subresource_filter_constants.cc
+++ b/components/subresource_filter/core/browser/subresource_filter_constants.cc
@@ -30,11 +30,4 @@ const base::FilePath::CharType kUnindexedRulesetLicenseFileName[] =
const base::FilePath::CharType kUnindexedRulesetDataFileName[] =
FILE_PATH_LITERAL("Filtering Rules");
-// TODO(shivanisha): Update the strings when finalized.
-
-const std::string kActivationConsoleMessage =
- "Subresource filter is activated on this site";
-
-const std::string kDisallowSubframeConsoleMessage =
- "Subresource filtering disallowed loading this resource, ";
} // namespace subresource_filter
« no previous file with comments | « components/subresource_filter/core/browser/subresource_filter_constants.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698