components/subresource_filter/core/browser/subresource_filter_constants.h - Issue 2936233004: [subresource_filter] Use constexpr for subresource filter dev tools messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/core/browser/subresource_filter_constants.h

Issue 2936233004: [subresource_filter] Use constexpr for subresource filter dev tools messages. (Closed)

Patch Set: Added include sstream Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/subresource_filter/subresource_filter_browsertest.cc ('k') | components/subresource_filter/core/browser/subresource_filter_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/core/browser/subresource_filter_constants.h

diff --git a/components/subresource_filter/core/browser/subresource_filter_constants.h b/components/subresource_filter/core/browser/subresource_filter_constants.h

index 9e3495840be20d965c7a54d2d8088a47d9630566..cd36c796dc8298c8cf9f9b7cc1d49a436ce7a16d 100644

--- a/components/subresource_filter/core/browser/subresource_filter_constants.h

+++ b/components/subresource_filter/core/browser/subresource_filter_constants.h

@@ -47,11 +47,14 @@ extern const base::FilePath::CharType kUnindexedRulesetLicenseFileName[];

// The name of the file that stores the unindexed filtering rules.

extern const base::FilePath::CharType kUnindexedRulesetDataFileName[];

+// TODO(shivanisha): Update the strings when finalized.

// Console message to be displayed on activation.

-extern const std::string kActivationConsoleMessage;

+constexpr char kActivationConsoleMessage[] =

+ "Subresource filter is activated on this site";

// Console message to be displayed on disallowing subframe.

-extern const std::string kDisallowSubframeConsoleMessage;

+constexpr char kDisallowSubframeConsoleMessage[] =

+ "Subresource filtering disallowed loading this resource, ";

} // namespace subresource_filter