Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 2935653002: [ios clean] Move dispatcher out of Browser.

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios clean] Move dispatcher out of Browser. This CL moves the dispatcher object out of Browser and makes it a property of BrowserCoordinatior. The root coordinator in a coordinator tree must create and own the dispatcher for its tree; child coordinators get handed a pointer to the dispatcher. This allows the creation of coordinator trees for generating proxy UI without risk of dispatcher collisions (by passing a nil dispatcher into the tree). Additionally, a 'callableDispatcher' property is added to BrowserCoordinator. This property is just the coordinator's dispatcher, cast to |id|. This is a convenience for passing the dispatcher into view controllers or other objects that don't know about the dispatcher itself. BUG=

Patch Set 1 #

Patch Set 2 : Dispatcher out of Browser. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -110 lines) Patch
M ios/clean/chrome/app/steps/root_coordinator+application_step.mm View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/context_menu/web_context_menu_coordinator.mm View 1 chunk +4 lines, -7 lines 0 comments Download
M ios/clean/chrome/browser/ui/find_in_page/find_in_page_coordinator.mm View 1 chunk +14 lines, -16 lines 0 comments Download
M ios/clean/chrome/browser/ui/ntp/ntp_coordinator.mm View 1 chunk +8 lines, -9 lines 0 comments Download
M ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm View 2 chunks +9 lines, -11 lines 0 comments Download
M ios/clean/chrome/browser/ui/settings/settings_coordinator.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/tab/tab_coordinator.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm View 5 chunks +21 lines, -27 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_strip/tab_strip_coordinator.mm View 1 3 chunks +8 lines, -8 lines 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm View 2 chunks +14 lines, -13 lines 0 comments Download
M ios/clean/chrome/browser/ui/tools/tools_coordinator.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/web_contents/web_coordinator.mm View 2 chunks +5 lines, -6 lines 0 comments Download
M ios/shared/chrome/browser/ui/browser_list/browser.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M ios/shared/chrome/browser/ui/browser_list/browser.mm View 1 2 chunks +0 lines, -2 lines 1 comment Download
M ios/shared/chrome/browser/ui/commands/command_dispatcher.mm View 1 chunk +3 lines, -1 line 0 comments Download
M ios/shared/chrome/browser/ui/coordinators/browser_coordinator.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M ios/shared/chrome/browser/ui/coordinators/browser_coordinator.mm View 1 4 chunks +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (1 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-12 09:48:20 UTC) #2
lpromero
lgtm
3 years, 6 months ago (2017-06-12 13:32:47 UTC) #3
marq (ping after 24h)
Ed and Rohit: ping? Most of the changes are just updating coordinators to get the ...
3 years, 6 months ago (2017-06-14 09:26:48 UTC) #4
rohitrao (ping after 24h)
It looks like the dispatcher is still owned by Browser, but now we're holding pointers ...
3 years, 6 months ago (2017-06-14 11:54:08 UTC) #5
marq (ping after 24h)
On 2017/06/14 11:54:08, rohitrao (ping after 24h) wrote: > It looks like the dispatcher is ...
3 years, 6 months ago (2017-06-16 13:13:22 UTC) #6
lpromero
3 years, 6 months ago (2017-06-16 14:47:22 UTC) #7
https://codereview.chromium.org/2935653002/diff/20001/ios/shared/chrome/brows...
File ios/shared/chrome/browser/ui/browser_list/browser.mm (left):

https://codereview.chromium.org/2935653002/diff/20001/ios/shared/chrome/brows...
ios/shared/chrome/browser/ui/browser_list/browser.mm:13: #import
"ios/shared/chrome/browser/ui/commands/command_dispatcher.h"
Nit: you might have a BUILD.gn file to modify too?

Powered by Google App Engine
This is Rietveld 408576698