ios/clean/chrome/browser/ui/tab_strip/tab_strip_coordinator.mm - Issue 2935653002: [ios clean] Move dispatcher out of Browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/ui/tab_strip/tab_strip_coordinator.mm

Issue 2935653002: [ios clean] Move dispatcher out of Browser.

Patch Set: Dispatcher out of Browser. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm ('k') | ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm » ('j') | ios/shared/chrome/browser/ui/browser_list/browser.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/clean/chrome/browser/ui/tab_strip/tab_strip_coordinator.mm

diff --git a/ios/clean/chrome/browser/ui/tab_strip/tab_strip_coordinator.mm b/ios/clean/chrome/browser/ui/tab_strip/tab_strip_coordinator.mm

index 8478ce5c7c9b4dc4281e6f42c1894128554e3984..e2572bb4f153f4e9e8d7d4ee6a8db8ade3523bb5 100644

--- a/ios/clean/chrome/browser/ui/tab_strip/tab_strip_coordinator.mm

+++ b/ios/clean/chrome/browser/ui/tab_strip/tab_strip_coordinator.mm

@@ -36,17 +36,17 @@

#pragma mark - BrowserCoordinator

- (void)start {

- CommandDispatcher* dispatcher = self.browser->dispatcher();

- [dispatcher startDispatchingToTarget:self

- forSelector:@selector(showTabStripTabAtIndex:)];

- [dispatcher startDispatchingToTarget:self

- forSelector:@selector(closeTabStripTabAtIndex:)];

+ [self.dispatcher startDispatchingToTarget:self

+ forSelector:@selector(showTabStripTabAtIndex:)];

+ [self.dispatcher

+ startDispatchingToTarget:self

+ forSelector:@selector(closeTabStripTabAtIndex:)];

self.viewController = [[TabStripViewController alloc] init];

self.mediator = [[TabCollectionMediator alloc] init];

self.mediator.webStateList = &self.webStateList;

self.mediator.consumer = self.viewController;

- self.viewController.dispatcher = static_cast<id>(self.browser->dispatcher());

+ self.viewController.dispatcher = self.callableDispatcher;

[super start];

}

@@ -54,7 +54,7 @@

- (void)stop {

[super stop];

[self.mediator disconnect];

- [self.browser->dispatcher() stopDispatchingToTarget:self];

+ [self.dispatcher stopDispatchingToTarget:self];

}

#pragma mark - TabStripCommands

@@ -66,7 +66,7 @@

- (void)closeTabStripTabAtIndex:(int)index {

self.webStateList.CloseWebStateAt(index);

if (self.webStateList.empty()) {

- [static_cast<id<TabGridCommands>>(self.browser->dispatcher()) showTabGrid];

+ [self.callableDispatcher showTabGrid];

}