Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: ios/clean/chrome/browser/ui/find_in_page/find_in_page_coordinator.mm

Issue 2935653002: [ios clean] Move dispatcher out of Browser.
Patch Set: Dispatcher out of Browser. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/find_in_page/find_in_page_coordinator.mm
diff --git a/ios/clean/chrome/browser/ui/find_in_page/find_in_page_coordinator.mm b/ios/clean/chrome/browser/ui/find_in_page/find_in_page_coordinator.mm
index 14acfc1c919cead1c6c09a6e0930a443bfe5d944..eae5ec2ee170e4f88c2db49192f126aeabd9a219 100644
--- a/ios/clean/chrome/browser/ui/find_in_page/find_in_page_coordinator.mm
+++ b/ios/clean/chrome/browser/ui/find_in_page/find_in_page_coordinator.mm
@@ -40,33 +40,31 @@
DCHECK(self.browser);
// Register command handlers with the dispatcher.
- CommandDispatcher* dispatcher = self.browser->dispatcher();
- [dispatcher startDispatchingToTarget:self
- forSelector:@selector(showFindInPage)];
- [dispatcher startDispatchingToTarget:self
- forSelector:@selector(hideFindInPage)];
+ [self.dispatcher startDispatchingToTarget:self
+ forSelector:@selector(showFindInPage)];
+ [self.dispatcher startDispatchingToTarget:self
+ forSelector:@selector(hideFindInPage)];
self.mediator = [[FindInPageMediator alloc]
initWithWebStateList:(&self.browser->web_state_list())provider:self
- dispatcher:static_cast<id>(dispatcher)];
- [dispatcher startDispatchingToTarget:self.mediator
- forSelector:@selector(findStringInPage:)];
- [dispatcher startDispatchingToTarget:self.mediator
- forSelector:@selector(findNextInPage)];
- [dispatcher startDispatchingToTarget:self.mediator
- forSelector:@selector(findPreviousInPage)];
+ dispatcher:self.callableDispatcher];
+ [self.dispatcher startDispatchingToTarget:self.mediator
+ forSelector:@selector(findStringInPage:)];
+ [self.dispatcher startDispatchingToTarget:self.mediator
+ forSelector:@selector(findNextInPage)];
+ [self.dispatcher startDispatchingToTarget:self.mediator
+ forSelector:@selector(findPreviousInPage)];
}
- (void)willBeRemovedFromParentCoordinator {
- CommandDispatcher* dispatcher = self.browser->dispatcher();
- [dispatcher stopDispatchingToTarget:self];
- [dispatcher stopDispatchingToTarget:self.mediator];
+ [self.dispatcher stopDispatchingToTarget:self];
+ [self.dispatcher stopDispatchingToTarget:self.mediator];
self.mediator = nil;
}
- (void)start {
self.viewController = [[FindInPageViewController alloc] init];
- self.viewController.dispatcher = static_cast<id>(self.browser->dispatcher());
+ self.viewController.dispatcher = self.callableDispatcher;
[super start];
}

Powered by Google App Engine
This is Rietveld 408576698