Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2935623003: Merge "cros: Move wallpaper after login screen is gone" (Closed)

Created:
3 years, 6 months ago by xiyuan
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, alemate+watch_chromium.org, sadrul, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, oshima+watch_chromium.org, achuith+watch_chromium.org, poromov+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, davemoore+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge "cros: Move wallpaper after login screen is gone" > - Make LoginDisplayHost::Finalize to take a callback to > be invoked just before login screen is dismissed; > - Set ACTIVE session state via the callback so that > wallpaper is moved to unlock container after login > screen is gone; > - Add LOGGED_IN_NOT_ACTIVE as another user session blocked > exception so that initial browser window created in > this state can be activated; > > BUG=718011 > > Review-Url: https://codereview.chromium.org/2891223002 > Cr-Commit-Position: refs/heads/master@{#474654} > (cherry picked from commit e6a229fa45aa9c57619d7e8f7bae4abe8351600c) Review-Url: https://codereview.chromium.org/2935623003 . Cr-Commit-Position: refs/branch-heads/3071@{#778} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/358a5df9871e31bdb8ee8b815dba6d3b2a905656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -60 lines) Patch
M ash/session/session_controller.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M ash/session/session_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_session_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/arc_kiosk_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/oobe_localization_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 9 chunks +23 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/ui/mock_login_display_host.h View 2 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
xiyuan
3 years, 6 months ago (2017-06-12 19:40:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
358a5df9871e31bdb8ee8b815dba6d3b2a905656.

Powered by Google App Engine
This is Rietveld 408576698