Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2934583002: Reland: chrome.webRequest support for ExtensionSettings (Closed)

Created:
3 years, 6 months ago by nrpeter
Modified:
3 years, 6 months ago
Reviewers:
*Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: chrome.webRequest support for ExtensionSettings Origional CL (2495353003) was rolled back by sheriff due to flaky test. This initial patchet is a direct patch of 2495353003. Second patchset contains the fix. chrome.webRequest support for ExtensionSettings -If URL or Origin matches an ExtensionSettings protected host, the event will not be dispatched to that extension / app. BUG=731269 patch from issue 2495353003 at patchset 400001 (http://crrev.com/2495353003#ps400001) Review-Url: https://codereview.chromium.org/2934583002 Cr-Commit-Position: refs/heads/master@{#478669} Committed: https://chromium.googlesource.com/chromium/src/+/ed5e8042ee77b69b64cab0b2c602878299341a22

Patch Set 1 : Initial import of 2495353003 #

Patch Set 2 : Fix flaky test ExtensionApiTestWithManagementPolicy.InitiatorProtectedByPolicy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -56 lines) Patch
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 1 6 chunks +218 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc View 4 chunks +39 lines, -32 lines 0 comments Download
M chrome/browser/extensions/extension_with_management_policy_apitest.h View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_with_management_policy_apitest.cc View 2 chunks +26 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webrequest/policy_blocked/background.js View 1 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webrequest/policy_blocked/manifest.json View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webrequest/policy_blocked/ref_remote_js.html View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webrequest/policy_blocked/ref_remote_js.js View 1 chunk +11 lines, -0 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_action.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +3 lines, -1 line 0 comments Download
M extensions/browser/api/web_request/web_request_permissions.h View 2 chunks +5 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/web_request_permissions.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M extensions/common/permissions/permissions_data.h View 2 chunks +8 lines, -6 lines 0 comments Download
M extensions/common/permissions/permissions_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
nrpeter
Tested locally on my machine for 100 runs, no failures.
3 years, 6 months ago (2017-06-09 20:19:56 UTC) #9
Devlin
lgtm
3 years, 6 months ago (2017-06-12 14:57:52 UTC) #12
Devlin
lgtm
3 years, 6 months ago (2017-06-12 14:57:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934583002/40001
3 years, 6 months ago (2017-06-12 15:37:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/235440)
3 years, 6 months ago (2017-06-12 16:50:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934583002/40001
3 years, 6 months ago (2017-06-12 17:05:36 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 17:40:57 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ed5e8042ee77b69b64cab0b2c602...

Powered by Google App Engine
This is Rietveld 408576698