Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_action.cc

Issue 2934583002: Reland: chrome.webRequest support for ExtensionSettings (Closed)
Patch Set: Fix flaky test ExtensionApiTestWithManagementPolicy.InitiatorProtectedByPolicy Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/declarative_webrequest/webrequest_action.cc
diff --git a/extensions/browser/api/declarative_webrequest/webrequest_action.cc b/extensions/browser/api/declarative_webrequest/webrequest_action.cc
index 39f945b63fa6b1ec6f58d23febdf52f3e94906c3..6c7589db27f423894ed7cd4c2be34172c9077b9e 100644
--- a/extensions/browser/api/declarative_webrequest/webrequest_action.cc
+++ b/extensions/browser/api/declarative_webrequest/webrequest_action.cc
@@ -516,8 +516,8 @@ bool WebRequestAction::HasPermission(ApplyInfo* apply_info,
// TODO(devlin): Pass in the real tab id here.
return WebRequestPermissions::CanExtensionAccessURL(
extension_info_map, extension_id, request->url(), -1,
- apply_info->crosses_incognito,
- permission_check) == PermissionsData::ACCESS_ALLOWED;
+ apply_info->crosses_incognito, permission_check,
+ request->initiator()) == PermissionsData::ACCESS_ALLOWED;
}
// static

Powered by Google App Engine
This is Rietveld 408576698