extensions/browser/api/web_request/web_request_api.cc - Issue 2934583002: Reland: chrome.webRequest support for ExtensionSettings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_api.cc

Issue 2934583002: Reland: chrome.webRequest support for ExtensionSettings (Closed)

Patch Set: Fix flaky test ExtensionApiTestWithManagementPolicy.InitiatorProtectedByPolicy Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/web_request/web_request_api.cc

diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc

index d2e230904eab9a3009dd1badf2bc0149b903aa46..4f29a2f69751fb00698f73a949d8cb1eff777580 100644

--- a/extensions/browser/api/web_request/web_request_api.cc

+++ b/extensions/browser/api/web_request/web_request_api.cc

@@ -1498,7 +1498,9 @@ void ExtensionWebRequestEventRouter::GetMatchingListenersImpl(

WebRequestPermissions::CanExtensionAccessURL(

extension_info_map, listener->id.extension_id, url,

frame_data.tab_id, crosses_incognito,

- WebRequestPermissions::REQUIRE_HOST_PERMISSION);

+ WebRequestPermissions::REQUIRE_HOST_PERMISSION,

+ request->initiator());

if (access != PermissionsData::ACCESS_ALLOWED) {

if (access == PermissionsData::ACCESS_WITHHELD &&

web_request_event_router_delegate_) {