Use ContainsValue() instead of std::find() in chrome/browser/chromeos

Use ContainsValue() instead of std::find() in chrome/browser/chromeos

BUG=561800
Review-Url: https://codereview.chromium.org/2934043002
Cr-Commit-Position: refs/heads/master@{#479348}
Committed: https://chromium.googlesource.com/chromium/src/+/5d879ddc96469aa44299cff009e796eee744cf24

[Tripta, 2017-06-13 09:31:44]

Description was changed from

==========
Use ContainsValue() instead of std::find() in chrome/browser/chromeos

BUG=561800
==========

to

==========
Use ContainsValue() instead of std::find() in chrome/browser/chromeos

BUG=561800
==========

[Tripta, 2017-06-13 09:31:44]

tripta.g@samsung.com changed reviewers:
+ zelidrag@chromium.org

[Tripta, 2017-06-13 09:33:43]

Hi zelidrag,

Please review code changes for below files:

  chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc
 
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc
  chrome/browser/chromeos/extensions/gfx_utils_unittest.cc
 
chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
 
chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
  chrome/browser/chromeos/input_method/input_method_manager_impl.cc
  chrome/browser/chromeos/login/screens/network_screen.cc
  chrome/browser/chromeos/mobile_config.cc
  chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
  chrome/browser/chromeos/policy/server_backed_state_keys_broker.cc

[achuithb, 2017-06-13 20:51:25]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 20:52:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2017-06-13 20:58:23]

Please CQ dry run before requesting comments.

lgtm with nits.

https://codereview.chromium.org/2934043002/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
(right):

https://codereview.chromium.org/2934043002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc:145:
bool HasProblem(CredentialProblem problem,
nit: we can eliminate this function entirely by inlining base::ContainsValue.

https://codereview.chromium.org/2934043002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/2934043002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:78: bool
Contains(const std::vector<std::string>& container,
nit: We can eliminate this function as well by inlining base::ContainsValue

https://codereview.chromium.org/2934043002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
(right):

https://codereview.chromium.org/2934043002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc:425: if
(!base::ContainsValue(whitelist_proto->user_whitelist(), user_id)) {
nit: drop {}

[commit-bot: I haz the power, 2017-06-13 21:32:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 21:32:58]

Dry run: This issue passed the CQ dry run.

[Tripta, 2017-06-14 07:32:01]

The CQ bit was checked by tripta.g@samsung.com

[Tripta, 2017-06-14 07:32:01]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2934043002/#ps40001
(title: "Removed function HasProblem and Contains.")

[commit-bot: I haz the power, 2017-06-14 07:32:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tripta, 2017-06-14 07:36:17]

Have made the changes. Please check.

Regards
Tripta

https://codereview.chromium.org/2934043002/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
(right):

https://codereview.chromium.org/2934043002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc:145:
bool HasProblem(CredentialProblem problem,
On 2017/06/13 20:58:23, achuithb wrote:
> nit: we can eliminate this function entirely by inlining base::ContainsValue.

Done.

https://codereview.chromium.org/2934043002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/2934043002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:78: bool
Contains(const std::vector<std::string>& container,
On 2017/06/13 20:58:23, achuithb wrote:
> nit: We can eliminate this function as well by inlining base::ContainsValue

Done.

https://codereview.chromium.org/2934043002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
(right):

https://codereview.chromium.org/2934043002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc:425: if
(!base::ContainsValue(whitelist_proto->user_whitelist(), user_id)) {
On 2017/06/13 20:58:23, achuithb wrote:
> nit: drop {}

Done.

[commit-bot: I haz the power, 2017-06-14 07:59:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 07:59:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tripta, 2017-06-14 08:30:36]

The CQ bit was checked by tripta.g@samsung.com

[commit-bot: I haz the power, 2017-06-14 08:30:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 08:56:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 08:56:05]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[achuithb, 2017-06-14 09:43:19]

lgtm % compilation fix

https://codereview.chromium.org/2934043002/diff/40001/chrome/browser/chromeos...
File
chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
(right):

https://codereview.chromium.org/2934043002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc:158:
base::ContainsValue(errors,CredentialProblem::CREDENTIAL_PROBLEM_TOO_SHORT);
You're missing closing ) here and below

[Tripta, 2017-06-14 10:32:46]

The CQ bit was checked by tripta.g@samsung.com

[Tripta, 2017-06-14 10:32:46]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2934043002/#ps60001
(title: "Fixed compilation error.")

[commit-bot: I haz the power, 2017-06-14 10:33:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tripta, 2017-06-14 10:47:36]

Fixed the error.

https://codereview.chromium.org/2934043002/diff/40001/chrome/browser/chromeos...
File
chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
(right):

https://codereview.chromium.org/2934043002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc:158:
base::ContainsValue(errors,CredentialProblem::CREDENTIAL_PROBLEM_TOO_SHORT);
On 2017/06/14 09:43:19, achuithb wrote:
> You're missing closing ) here and below

Done.

[commit-bot: I haz the power, 2017-06-14 11:05:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497436366200070,
"parent_rev": "d95830c60e22fa695f0521004149caf03bcc2f77", "commit_rev":
"5d879ddc96469aa44299cff009e796eee744cf24"}

[commit-bot: I haz the power, 2017-06-14 11:06:04]

Description was changed from

==========
Use ContainsValue() instead of std::find() in chrome/browser/chromeos

BUG=561800
==========

to

==========
Use ContainsValue() instead of std::find() in chrome/browser/chromeos

BUG=561800

Review-Url: https://codereview.chromium.org/2934043002
Cr-Commit-Position: refs/heads/master@{#479348}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d879ddc96469aa44299cff009e7...
==========

[commit-bot: I haz the power, 2017-06-14 11:06:06]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5d879ddc96469aa44299cff009e7...