chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc - Issue 2934043002: Use ContainsValue() instead of std::find() in chrome/browser/chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc

Issue 2934043002: Use ContainsValue() instead of std::find() in chrome/browser/chromeos (Closed)

Patch Set: Fixed compilation error. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc ('k') | chrome/browser/chromeos/extensions/gfx_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc

diff --git a/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc b/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc

index aef05cca1b38ae33127bfd126a754e6e26d6dd21..ee4517b3a6792b8d4dc62b262f77c684d5b55674 100644

--- a/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc

+++ b/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc

@@ -4,11 +4,11 @@

#include "chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.h"

-#include <algorithm>

#include <vector>

#include "ash/shell.h"

#include "ash/test/ash_test_base.h"

+#include "base/stl_util.h"

#include "chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.h"

#include "ui/display/display.h"

#include "ui/display/manager/display_manager.h"

@@ -77,9 +77,7 @@ TEST_F(TouchCalibratorControllerTest, StartCalibration) {

ui::EventTargetTestApi test_api(ash::Shell::Get());

const ui::EventHandlerList& handlers = test_api.pre_target_handlers();

- ui::EventHandlerList::const_iterator event_target =

- std::find(handlers.begin(), handlers.end(), &touch_calibrator_controller);

- EXPECT_NE(event_target, handlers.end());

+ EXPECT_TRUE(base::ContainsValue(handlers, &touch_calibrator_controller));

}

TEST_F(TouchCalibratorControllerTest, KeyEventIntercept) {