Use ContainsValue() instead of std::find() in chrome/browser/chromeos

chrome/browser/chromeos/input_method/input_method_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/input_method/input_method_manager_impl.h"
 
 #include <stdint.h>
 
 #include <algorithm>  // std::find
 #include <memory>
 #include <set>
 #include <sstream>
 #include <utility>
 
 #include "ash/ime/ime_controller.h"
 #include "ash/public/interfaces/ime_info.mojom.h"
 #include "ash/shell.h"
 #include "base/bind.h"
 #include "base/feature_list.h"
 #include "base/hash.h"
 #include "base/location.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/sparse_histogram.h"
+#include "base/stl_util.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_process_platform_part_chromeos.h"
 #include "chrome/browser/chromeos/ash_config.h"
 #include "chrome/browser/chromeos/input_method/candidate_window_controller.h"
 #include "chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h"
 #include "chrome/browser/chromeos/language_preferences.h"
 #include "chrome/browser/chromeos/login/session/user_session_manager.h"
@@ skipping 32 matching lines @@
                                   const InputMethodUtil& util) {
   ash::mojom::ImeInfo info;
   info.id = ime.id();
   info.name = util.GetInputMethodLongName(ime);
   info.medium_name = util.GetInputMethodMediumName(ime);
   info.short_name = util.GetInputMethodShortName(ime);
   info.third_party = extension_ime_util::IsExtensionIME(ime.id());
   return info;
 }
 
 bool Contains(const std::vector<std::string>& container,

[achuithb, 2017/06/13 20:58:23]

nit: We can eliminate this function as well by inlining base::ContainsValue

[Tripta, 2017/06/14 07:36:17]

Done.

               const std::string& value) {
-  return std::find(container.begin(), container.end(), value) !=
-      container.end();
+  return base::ContainsValue(container, value);
 }
 
 enum InputMethodCategory {
   INPUT_METHOD_CATEGORY_UNKNOWN = 0,
   INPUT_METHOD_CATEGORY_XKB,  // XKB input methods
   INPUT_METHOD_CATEGORY_ZH,   // Chinese input methods
   INPUT_METHOD_CATEGORY_JA,   // Japanese input methods
   INPUT_METHOD_CATEGORY_KO,   // Korean input methods
   INPUT_METHOD_CATEGORY_M17N, // Multilingualization input methods
   INPUT_METHOD_CATEGORY_T13N, // Transliteration input methods
@@ skipping 1325 matching lines @@
     property.key = menu_list[i].key;
     property.label = base::UTF8ToUTF16(menu_list[i].label);
     property.checked = menu_list[i].is_selection_item_checked;
     items.push_back(property);
   }
   return items;
 }
 
 }  // namespace input_method
 }  // namespace chromeos