Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2933943002: Convert more tests to the new driver (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -242 lines) Patch
M pkg/analysis_server/test/analysis/notification_highlights_test.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test2.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_occurrences_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_outline_test.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_overrides_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/reanalyze_test.dart View 4 chunks +11 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/analysis/set_priority_files_test.dart View 7 chunks +18 lines, -31 lines 2 comments Download
M pkg/analysis_server/test/edit/organize_directives_test.dart View 5 chunks +2 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/edit/sort_members_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
D pkg/analysis_server/test/plugin/set_analysis_domain_test.dart View 1 chunk +0 lines, -167 lines 0 comments Download
M pkg/analysis_server/test/plugin/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
One test class was deleted because I think we don't intend to support this API ...
3 years, 6 months ago (2017-06-12 21:03:32 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2933943002/diff/1/pkg/analysis_server/test/analysis/set_priority_files_test.dart File pkg/analysis_server/test/analysis/set_priority_files_test.dart (right): https://codereview.chromium.org/2933943002/diff/1/pkg/analysis_server/test/analysis/set_priority_files_test.dart#newcode135 pkg/analysis_server/test/analysis/set_priority_files_test.dart:135: expect(prioritySources, hasLength(1)); It could be just expect(driver.priorityFiles, [path]);
3 years, 6 months ago (2017-06-12 21:07:40 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2933943002/diff/1/pkg/analysis_server/test/analysis/set_priority_files_test.dart File pkg/analysis_server/test/analysis/set_priority_files_test.dart (right): https://codereview.chromium.org/2933943002/diff/1/pkg/analysis_server/test/analysis/set_priority_files_test.dart#newcode135 pkg/analysis_server/test/analysis/set_priority_files_test.dart:135: expect(prioritySources, hasLength(1)); Done
3 years, 6 months ago (2017-06-12 21:09:49 UTC) #4
Brian Wilkerson
3 years, 6 months ago (2017-06-12 21:10:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
67ff4d4c47d688375887b19cea530647d4f9b41d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698