Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Unified Diff: pkg/analysis_server/test/edit/organize_directives_test.dart

Issue 2933943002: Convert more tests to the new driver (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/edit/organize_directives_test.dart
diff --git a/pkg/analysis_server/test/edit/organize_directives_test.dart b/pkg/analysis_server/test/edit/organize_directives_test.dart
index 3d093fb5762b992a43ecb167b05445c61bcca9ee..34ec28d767b33f65b5ad2dd63be3a01d9cfcabb0 100644
--- a/pkg/analysis_server/test/edit/organize_directives_test.dart
+++ b/pkg/analysis_server/test/edit/organize_directives_test.dart
@@ -26,9 +26,6 @@ class OrganizeDirectivesTest extends AbstractAnalysisTest {
SourceFileEdit fileEdit;
@override
- bool get enableNewAnalysisDriver => false;
-
- @override
void setUp() {
super.setUp();
createProject();
@@ -37,8 +34,9 @@ class OrganizeDirectivesTest extends AbstractAnalysisTest {
handler = new EditDomainHandler(server);
}
+ @failingTest
Future test_BAD_doesNotExist() async {
- await waitForTasksFinished();
+ // The analysis driver fails to return an error
Request request =
new EditOrganizeDirectivesParams('/no/such/file.dart').toRequest('0');
Response response = await waitResponse(request);
@@ -52,7 +50,6 @@ import 'dart:async'
main() {}
''');
- await waitForTasksFinished();
Request request = new EditOrganizeDirectivesParams(testFile).toRequest('0');
Response response = await waitResponse(request);
expect(response,
@@ -60,7 +57,6 @@ main() {}
}
Future test_BAD_notDartFile() async {
- await waitForTasksFinished();
Request request =
new EditOrganizeDirectivesParams('/not-a-Dart-file.txt').toRequest('0');
Response response = await waitResponse(request);
@@ -160,7 +156,6 @@ main() {
}
Future _assertOrganized(String expectedCode) async {
- await waitForTasksFinished();
await _requestOrganize();
String resultCode = SourceEdit.applySequence(testCode, fileEdit.edits);
expect(resultCode, expectedCode);

Powered by Google App Engine
This is Rietveld 408576698