Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: pkg/analysis_server/test/analysis/notification_highlights_test2.dart

Issue 2933943002: Convert more tests to the new driver (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis/notification_highlights_test2.dart
diff --git a/pkg/analysis_server/test/analysis/notification_highlights_test2.dart b/pkg/analysis_server/test/analysis/notification_highlights_test2.dart
index 56de971b1a721ed000b660ecf581137659a1597f..60246e5a8060a0204c3534c53047e2477ba2ab27 100644
--- a/pkg/analysis_server/test/analysis/notification_highlights_test2.dart
+++ b/pkg/analysis_server/test/analysis/notification_highlights_test2.dart
@@ -24,8 +24,7 @@ main() {
class AnalysisNotificationHighlightsTest extends AbstractAnalysisTest {
List<HighlightRegion> regions;
- @override
- bool get enableNewAnalysisDriver => false;
+ Completer _resultsAvailable = new Completer();
void assertHasRawRegion(HighlightRegionType type, int offset, int length) {
for (HighlightRegion region in regions) {
@@ -93,7 +92,7 @@ class AnalysisNotificationHighlightsTest extends AbstractAnalysisTest {
Future prepareHighlights() {
addAnalysisSubscription(AnalysisService.HIGHLIGHTS, testFile);
- return waitForTasksFinished();
+ return _resultsAvailable.future;
}
void processNotification(Notification notification) {
@@ -101,6 +100,7 @@ class AnalysisNotificationHighlightsTest extends AbstractAnalysisTest {
var params = new AnalysisHighlightsParams.fromNotification(notification);
if (params.file == testFile) {
regions = params.regions;
+ _resultsAvailable.complete(null);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698