Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: pkg/analysis_server/test/analysis/notification_overrides_test.dart

Issue 2933943002: Convert more tests to the new driver (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis/notification_overrides_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_overrides_test.dart b/pkg/analysis_server/test/analysis/notification_overrides_test.dart
index b2dcc5e3b58d925b55135eb5e3c5bfc943905975..a64cc1b1b56bb8e34898619a7d6937f370dc7b4e 100644
--- a/pkg/analysis_server/test/analysis/notification_overrides_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_overrides_test.dart
@@ -23,7 +23,7 @@ class AnalysisNotificationOverridesTest extends AbstractAnalysisTest {
List<Override> overridesList;
Override override;
- bool get enableNewAnalysisDriver => false;
+ Completer _resultsAvailable = new Completer();
/**
* Asserts that there is an overridden interface [OverriddenMember] at the
@@ -119,7 +119,7 @@ class AnalysisNotificationOverridesTest extends AbstractAnalysisTest {
Future prepareOverrides() {
addAnalysisSubscription(AnalysisService.OVERRIDES, testFile);
- return waitForTasksFinished();
+ return _resultsAvailable.future;
}
void processNotification(Notification notification) {
@@ -127,6 +127,7 @@ class AnalysisNotificationOverridesTest extends AbstractAnalysisTest {
var params = new AnalysisOverridesParams.fromNotification(notification);
if (params.file == testFile) {
overridesList = params.overrides;
+ _resultsAvailable.complete(null);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698