Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest

Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest

AwJUnit4ClassRunner automatically duplicate test methods into
single process mode test and multiprocess mode test.

The multiprocess test would run with AwSwitches.WEBVIEW_SANDBOXED_RENDERER
as one of its commandline switches.

@SkipCommandLineParameterization is added for test method or class to skip
parameterization.

This CL also create AwActivityTestRule which shares implementation for
helper methods with AwTestBase under AwTestCommon. The CL converts
AwContentsTest to JUnit4 as an example.

For more on JUnit4 migration, please check src/testing/android/docs/junit4.md

BUG=640116

[the real yoland, 2017-06-09 21:40:37]

https://codereview.chromium.org/2933623002/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwSimpleTest.java
(right):

https://codereview.chromium.org/2933623002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/AwSimpleTest.java:1:
// Copyright 2012 The Chromium Authors. All rights reserved.
Please ignore this, added for debugging reason

https://codereview.chromium.org/2933623002/diff/1/android_webview/test/shell/...
File
android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java
(right):

https://codereview.chromium.org/2933623002/diff/1/android_webview/test/shell/...
android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java:52:
// Log.d("#YOLAND", new WebViewParameterizedFrameworkMethod(method).getName());
Please ignore the loggings, added for debugging reasons

[the real yoland, 2017-06-12 21:51:02]

take out the Logs

[the real yoland, 2017-07-20 02:40:42]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-20 02:40:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[the real yoland, 2017-07-20 02:41:11]

yolandyan@chromium.org changed reviewers:
+ boliu@chromium.org, jbudorick@chromium.org, mikecase@chromium.org,
sgurun@chromium.org

[the real yoland, 2017-07-20 02:41:29]

Description was changed from

==========
Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest

AwJUnit4ClassRunner automatically duplicate test methods into
parameterized test with name postfix and non parameterized test.
The parameterized test would run with AwSwitches.WEBVIEW_SANDBOXED_RENDERER
as one of its commandline switches.

@SkipWebViewParameterization is added for test method or class to skip
parameterization.

This CL also create AwActivityTestRule which shares implementation for
helper methods with AwTestBase under AwTestCommon. The CL converts
AwContentsTest to JUnit4 as an example.

For more on JUnit4 migration, please check src/testing/android/docs/junit4.md

BUG=640116
==========

to

==========
Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest

AwJUnit4ClassRunner automatically duplicate test methods into
parameterized test with name postfix and non parameterized test.
The parameterized test would run with AwSwitches.WEBVIEW_SANDBOXED_RENDERER
as one of its commandline switches.

@SkipCommandLineParameterization is added for test method or class to skip
parameterization.

This CL also create AwActivityTestRule which shares implementation for
helper methods with AwTestBase under AwTestCommon. The CL converts
AwContentsTest to JUnit4 as an example.

For more on JUnit4 migration, please check src/testing/android/docs/junit4.md

BUG=640116
==========

[commit-bot: I haz the power, 2017-07-20 05:15:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-20 05:15:07]

Dry run: This issue passed the CQ dry run.

[boliu, 2017-07-20 21:22:48]

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
(left):

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java:455:
String xfoo = getJavaScriptResultBodyTextContent(awContents, mContentsClient);
add this to Rules?

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
(right):

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java:41:
import org.chromium.base.test.util.parameter.SkipCommandLineParameterization;
does all of these imports needs to be fixed now? or only tests that convert to
junit4?

maybe should double check number of tests doesn't change after this CL..

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
(right):

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java:45:
* @SkipCommandLineParameterization
fix this comment

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
File
android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java
(right):

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java:368:
// In theory we need two servers to test getInstrumentation(), one server ('the
first
wrong thing to sed over :p

https://codereview.chromium.org/2933623002/diff/20001/android_webview/test/sh...
File
android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java
(right):

https://codereview.chromium.org/2933623002/diff/20001/android_webview/test/sh...
android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java:58:
if (method instanceof WebViewParameterizedFrameworkMethod) {
I think you can be a bit more specific with the names. Just say something about
SingleAndMultiProcess, or SingleProcessOnly.

https://codereview.chromium.org/2933623002/diff/20001/android_webview/test/sh...
android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java:73:
return super.getName() + "__sandboxed_mode";
__multiprocess_mode?

https://codereview.chromium.org/2933623002/diff/20001/android_webview/test/sh...
android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java:77:
public boolean equals(Object obj) {
are these two necessary?

https://codereview.chromium.org/2933623002/diff/20001/android_webview/test/sh...
File
android_webview/test/shell/src/org/chromium/android_webview/test/WebViewParameterization.java
(right):

https://codereview.chromium.org/2933623002/diff/20001/android_webview/test/sh...
android_webview/test/shell/src/org/chromium/android_webview/test/WebViewParameterization.java:20:
public @interface WebViewParameterization {}
not used?

[the real yoland, 2017-07-27 00:27:32]

Description was changed from

==========
Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest

AwJUnit4ClassRunner automatically duplicate test methods into
parameterized test with name postfix and non parameterized test.
The parameterized test would run with AwSwitches.WEBVIEW_SANDBOXED_RENDERER
as one of its commandline switches.

@SkipCommandLineParameterization is added for test method or class to skip
parameterization.

This CL also create AwActivityTestRule which shares implementation for
helper methods with AwTestBase under AwTestCommon. The CL converts
AwContentsTest to JUnit4 as an example.

For more on JUnit4 migration, please check src/testing/android/docs/junit4.md

BUG=640116
==========

to

==========
Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest

AwJUnit4ClassRunner automatically duplicate test methods into
single process mode test and multiprocess mode test.

The multiprocess test would run with AwSwitches.WEBVIEW_SANDBOXED_RENDERER
as one of its commandline switches.

@SkipCommandLineParameterization is added for test method or class to skip
parameterization.

This CL also create AwActivityTestRule which shares implementation for
helper methods with AwTestBase under AwTestCommon. The CL converts
AwContentsTest to JUnit4 as an example.

For more on JUnit4 migration, please check src/testing/android/docs/junit4.md

BUG=640116
==========

[the real yoland, 2017-07-27 00:29:48]

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
(left):

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java:455:
String xfoo = getJavaScriptResultBodyTextContent(awContents, mContentsClient);
On 2017/07/20 at 21:22:47, boliu wrote:
> add this to Rules?

Done

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
(right):

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java:41:
import org.chromium.base.test.util.parameter.SkipCommandLineParameterization;
On 2017/07/20 at 21:22:47, boliu wrote:
> does all of these imports needs to be fixed now? or only tests that convert to
junit4?
> 
> maybe should double check number of tests doesn't change after this CL..

I was able to verify locally that the number of AwContentTests tests gone for 23
test methods to 43 (not double because
of skip commandline parameterization test)

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
(right):

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java:45:
* @SkipCommandLineParameterization
On 2017/07/20 at 21:22:47, boliu wrote:
> fix this comment

Done

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
File
android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java
(right):

https://codereview.chromium.org/2933623002/diff/20001/android_webview/javates...
android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java:368:
// In theory we need two servers to test getInstrumentation(), one server ('the
first
On 2017/07/20 at 21:22:47, boliu wrote:
> wrong thing to sed over :p

lol, yup

https://codereview.chromium.org/2933623002/diff/20001/android_webview/test/sh...
File
android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java
(right):

https://codereview.chromium.org/2933623002/diff/20001/android_webview/test/sh...
android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java:58:
if (method instanceof WebViewParameterizedFrameworkMethod) {
On 2017/07/20 at 21:22:47, boliu wrote:
> I think you can be a bit more specific with the names. Just say something
about SingleAndMultiProcess, or SingleProcessOnly.

Done

https://codereview.chromium.org/2933623002/diff/20001/android_webview/test/sh...
android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java:73:
return super.getName() + "__sandboxed_mode";
On 2017/07/20 at 21:22:48, boliu wrote:
> __multiprocess_mode?

Done

https://codereview.chromium.org/2933623002/diff/20001/android_webview/test/sh...
android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java:77:
public boolean equals(Object obj) {
On 2017/07/20 at 21:22:47, boliu wrote:
> are these two necessary?

Yes, I encounter a bug where the test runner ask for testA__sandboxed_mode, but
testA == testA__sandboex_mode is true without this.

https://codereview.chromium.org/2933623002/diff/20001/android_webview/test/sh...
File
android_webview/test/shell/src/org/chromium/android_webview/test/WebViewParameterization.java
(right):

https://codereview.chromium.org/2933623002/diff/20001/android_webview/test/sh...
android_webview/test/shell/src/org/chromium/android_webview/test/WebViewParameterization.java:20:
public @interface WebViewParameterization {}
On 2017/07/20 at 21:22:48, boliu wrote:
> not used?

Removed

[the real yoland, 2017-07-27 00:29:52]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-27 00:30:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-27 01:42:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-27 01:42:56]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[boliu, 2017-07-27 17:32:18]

are the base changes relevant?

also looks like a bunch of webview tests failed

https://codereview.chromium.org/2933623002/diff/40001/android_webview/test/sh...
File
android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java
(right):

https://codereview.chromium.org/2933623002/diff/40001/android_webview/test/sh...
android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java:47:
Log.w("#YOLAND-SIZE",
no random logs, and below