Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest

android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview.test;
 
 import android.support.test.filters.MediumTest;
 import android.test.MoreAsserts;
 import android.util.Pair;
 import android.webkit.ValueCallback;
@@ skipping 96 matching lines @@
             cookie = mCookieManager.getCookie(url);
             assertNotNull(cookie);
             validateCookies(cookie, "test2", "header-test2");
         } finally {
             webServer.shutdown();
         }
     }
 
     private void setCookieWithJavaScript(final String name, final String value)
             throws Throwable {
-        JSUtils.executeJavaScriptAndWaitForResult(
-                this, mAwContents,
+        JSUtils.executeJavaScriptAndWaitForResult(getInstrumentation(), mAwContents,
                 mContentsClient.getOnEvaluateJavaScriptResultHelper(),
                 "var expirationDate = new Date();"
-                + "expirationDate.setDate(expirationDate.getDate() + 5);"
-                + "document.cookie='" + name + "=" + value
-                + "; expires=' + expirationDate.toUTCString();");
+                        + "expirationDate.setDate(expirationDate.getDate() + 5);"
+                        + "document.cookie='" + name + "=" + value
+                        + "; expires=' + expirationDate.toUTCString();");
     }
 
     @MediumTest
     @Feature({"AndroidWebView", "Privacy"})
     public void testRemoveAllCookies() throws Exception {
         mCookieManager.setCookie("http://www.example.com", "name=test");
         assertTrue(mCookieManager.hasCookies());
         mCookieManager.removeAllCookies();
         assertFalse(mCookieManager.hasCookies());
     }
@@ skipping 225 matching lines @@
         mCookieManager.removeExpiredCookies();
 
         allCookies = mCookieManager.getCookie(url);
         assertTrue(allCookies.contains(sessionCookie));
         assertTrue(allCookies.contains(longCookie));
     }
 
     @MediumTest
     @Feature({"AndroidWebView", "Privacy"})
     public void testThirdPartyCookie() throws Throwable {
-        // In theory we need two servers to test this, one server ('the first party') which returns
-        // a response with a link to a second server ('the third party') at different origin. This
-        // second server attempts to set a cookie which should fail if AcceptThirdPartyCookie() is
-        // false.
-        // Strictly according to the letter of RFC6454 it should be possible to set this situation
-        // up with two TestServers on different ports (these count as having different origins) but
-        // Chrome is not strict about this and does not check the port. Instead we cheat making some
-        // of the urls come from localhost and some from 127.0.0.1 which count (both in theory and
-        // pratice) as having different origins.
+        // In theory we need two servers to test getInstrumentation(), one server ('the first

[boliu, 2017/07/20 21:22:47]

wrong thing to sed over :p

[the real yoland, 2017/07/27 00:29:47]

lol, yup

+        // party') which returns a response with a link to a second server ('the third party') at
+        // different origin. This second server attempts to set a cookie which should fail if
+        // AcceptThirdPartyCookie() is false. Strictly according to the letter of RFC6454 it should
+        // be possible to set this situation up with two TestServers on different ports (these count
+        // as having different origins) but Chrome is not strict about this and does not check the
+        // port. Instead we cheat making some of the urls come from localhost and some from
+        // 127.0.0.1 which count (both in theory and pratice) as having different origins.
         TestWebServer webServer = TestWebServer.start();
         try {
             // Turn global allow on.
             mCookieManager.setAcceptCookie(true);
             assertTrue(mCookieManager.acceptCookie());
 
             // When third party cookies are disabled...
             mAwContents.getSettings().setAcceptThirdPartyCookies(false);
             assertFalse(mAwContents.getSettings().getAcceptThirdPartyCookies());
 
@@ skipping 388 matching lines @@
         return makeExpiringCookieMs(cookie, secondsTillExpiry * 1000);
     }
 
     @SuppressWarnings("deprecation")
     private String makeExpiringCookieMs(String cookie, int millisecondsTillExpiry) {
         Date date = new Date();
         date.setTime(date.getTime() + millisecondsTillExpiry);
         return cookie + "; expires=" + date.toGMTString();
     }
 }