android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java - Issue 2933623002: Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

Issue 2933623002: Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest (Closed)

Patch Set: address bo's comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java » ('j') | android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

index 5ac1e2500b23a697e7c945d88a3653d8c7b06faf..675ff54b96ed8e699b832300477c6024be0940ac 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

@@ -288,8 +288,8 @@ public class LoadUrlTest extends AwTestBase {

validateHeadersValue(awContents, contentsClient, extraHeaders, true);

int currentCallCount = contentsClient.getOnPageFinishedHelper().getCallCount();

- JSUtils.clickOnLinkUsingJs(

- this, awContents, contentsClient.getOnEvaluateJavaScriptResultHelper(), "click");

+ JSUtils.clickOnLinkUsingJs(getInstrumentation(), awContents,

+ contentsClient.getOnEvaluateJavaScriptResultHelper(), "click");

contentsClient.getOnPageFinishedHelper().waitForCallback(

currentCallCount, 1, WAIT_TIMEOUT_MS, TimeUnit.MILLISECONDS);

// No extra headers for the page navigated via clicking.