Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 2933363002: [ObjC ARC] Converts ios/web:ios_web_web_state_ui_unittests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web:ios_web_web_state_ui_unittests to ARC. Automatically generated ARCMigrate commit Notable issues: Removed WKBackForwardListItemHolderTest.GetNilBackForwardListItemFromHolder, since it amounts to being a test of WeakNSPointer, and there's no guarantees about object lifetimes under ARC. BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2933363002 Cr-Commit-Position: refs/heads/master@{#479462} Committed: https://chromium.googlesource.com/chromium/src/+/e903119df72bd16ed4682c9e1c88ec9caeb81238

Patch Set 1 #

Patch Set 2 : removed spurious test. #

Total comments: 7

Patch Set 3 : Review nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -144 lines) Patch
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view_unittest.mm View 1 5 chunks +14 lines, -12 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_observer_unittest.mm View 2 chunks +7 lines, -6 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 2 13 chunks +33 lines, -33 lines 0 comments Download
M ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm View 3 chunks +18 lines, -19 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm View 3 chunks +9 lines, -6 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_script_message_router_unittest.mm View 1 4 chunks +31 lines, -28 lines 0 comments Download
M ios/web/web_state/ui/web_view_js_utils_unittest.mm View 3 chunks +6 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm View 1 3 chunks +6 lines, -26 lines 0 comments Download
M ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm View 5 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
marq (ping after 24h)
removed spurious test.
3 years, 6 months ago (2017-06-14 13:21:01 UTC) #5
marq (ping after 24h)
3 years, 6 months ago (2017-06-14 13:22:31 UTC) #10
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/crw_web_controller_unittest.mm File ios/web/web_state/ui/crw_web_controller_unittest.mm (right): https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/crw_web_controller_unittest.mm#newcode128 ios/web/web_state/ui/crw_web_controller_unittest.mm:128: TestWebViewContentView* webViewContentView = Optional nit: s/webViewContentView/web_view_content_view https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/crw_web_controller_unittest.mm#newcode206 ios/web/web_state/ui/crw_web_controller_unittest.mm:206: ...
3 years, 6 months ago (2017-06-14 13:42:21 UTC) #11
marq (ping after 24h)
Thanks for the quick review! https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/crw_web_controller_unittest.mm File ios/web/web_state/ui/crw_web_controller_unittest.mm (right): https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/crw_web_controller_unittest.mm#newcode128 ios/web/web_state/ui/crw_web_controller_unittest.mm:128: TestWebViewContentView* webViewContentView = On ...
3 years, 6 months ago (2017-06-14 14:19:03 UTC) #12
marq (ping after 24h)
Review nits.
3 years, 6 months ago (2017-06-14 14:20:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933363002/40001
3 years, 6 months ago (2017-06-14 14:20:33 UTC) #16
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm File ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm (left): https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm#oldcode109 ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm:109: TEST_F(WKBackForwardListItemHolderTest, GetNilBackForwardListItemFromHolder) { On 2017/06/14 14:19:02, marq (ping after ...
3 years, 6 months ago (2017-06-14 14:25:53 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/199756)
3 years, 6 months ago (2017-06-14 16:26:38 UTC) #19
marq (ping after 24h)
On 2017/06/14 16:26:38, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 6 months ago (2017-06-14 17:02:09 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933363002/40001
3 years, 6 months ago (2017-06-14 17:02:24 UTC) #22
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 19:11:23 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e903119df72bd16ed4682c9e1c88...

Powered by Google App Engine
This is Rietveld 408576698