[ObjC ARC] Converts ios/web:ios_web_web_state_ui_unittests to ARC.

[ObjC ARC] Converts ios/web:ios_web_web_state_ui_unittests to ARC.

Automatically generated ARCMigrate commit

Notable issues:

Removed WKBackForwardListItemHolderTest.GetNilBackForwardListItemFromHolder,
since it amounts to being a test of WeakNSPointer, and there's no guarantees about
object lifetimes under ARC.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2933363002
Cr-Commit-Position: refs/heads/master@{#479462}
Committed: https://chromium.googlesource.com/chromium/src/+/e903119df72bd16ed4682c9e1c88ec9caeb81238

[marq (ping after 24h), 2017-06-13 16:27:48]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 16:28:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 17:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:00:37]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[marq (ping after 24h), 2017-06-14 13:21:01]

removed spurious test.

[marq (ping after 24h), 2017-06-14 13:22:07]

Description was changed from

==========
[ObjC ARC] Converts ios/web:ios_web_web_state_ui_unittests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/web:ios_web_web_state_ui_unittests to ARC.

Automatically generated ARCMigrate commit

Notable issues:

Removed WKBackForwardListItemHolderTest.GetNilBackForwardListItemFromHolder,
since it amounts to being a test of WeakNSPointer, and there's no guarantees
about
object lifetimes under ARC.

BUG=624363
TEST=None
==========

[marq (ping after 24h), 2017-06-14 13:22:15]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 13:22:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marq (ping after 24h), 2017-06-14 13:22:30]

marq@chromium.org changed reviewers:
+ eugenebut@chromium.org, stkhapugin@chromium.org

[Eugene But (OOO till 7-30), 2017-06-14 13:42:21]

lgtm

https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller_unittest.mm (right):

https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller_unittest.mm:128: TestWebViewContentView*
webViewContentView =
Optional nit: s/webViewContentView/web_view_content_view

https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller_unittest.mm:206: (__bridge
NSArray*)chain.get(),
Is there anything in foundation_util.h which you can use instead of bridge cast?

https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/wk...
File ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm (left):

https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/wk...
ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm:109:
TEST_F(WKBackForwardListItemHolderTest, GetNilBackForwardListItemFromHolder) {
Sad.

[marq (ping after 24h), 2017-06-14 14:19:03]

Thanks for the quick review!

https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller_unittest.mm (right):

https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller_unittest.mm:128: TestWebViewContentView*
webViewContentView =
On 2017/06/14 13:42:20, Eugene But wrote:
> Optional nit: s/webViewContentView/web_view_content_view

Done.

https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller_unittest.mm:206: (__bridge
NSArray*)chain.get(),
On 2017/06/14 13:42:20, Eugene But wrote:
> Is there anything in foundation_util.h which you can use instead of bridge
cast?

Done.

https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/wk...
File ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm (left):

https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/wk...
ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm:109:
TEST_F(WKBackForwardListItemHolderTest, GetNilBackForwardListItemFromHolder) {
On 2017/06/14 13:42:20, Eugene But wrote:
> Sad.

Sad that the test was removed, or that it was there in the first place?

[marq (ping after 24h), 2017-06-14 14:20:24]

Review nits.

[marq (ping after 24h), 2017-06-14 14:20:25]

The CQ bit was checked by marq@chromium.org

[marq (ping after 24h), 2017-06-14 14:20:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2933363002/#ps40001
(title: "Review nits.")

[commit-bot: I haz the power, 2017-06-14 14:20:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2017-06-14 14:25:53]

https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/wk...
File ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm (left):

https://codereview.chromium.org/2933363002/diff/20001/ios/web/web_state/ui/wk...
ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm:109:
TEST_F(WKBackForwardListItemHolderTest, GetNilBackForwardListItemFromHolder) {
On 2017/06/14 14:19:02, marq (ping after 24h) wrote:
> On 2017/06/14 13:42:20, Eugene But wrote:
> > Sad.
> 
> Sad that the test was removed, or that it was there in the first place?
That it was removed :)
I guess you think it was sad that test existed in the first place.

[commit-bot: I haz the power, 2017-06-14 16:26:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 16:26:38]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[marq (ping after 24h), 2017-06-14 17:02:02]

The CQ bit was checked by marq@chromium.org

[marq (ping after 24h), 2017-06-14 17:02:09]

On 2017/06/14 16:26:38, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

It seemed to me that it was just testing that a weak pointer behaved as
expected.

[commit-bot: I haz the power, 2017-06-14 17:02:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 19:11:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497459722303500,
"parent_rev": "296a2fd2ea8e56d22279511c8dbe583c5cfa8d83", "commit_rev":
"e903119df72bd16ed4682c9e1c88ec9caeb81238"}

[commit-bot: I haz the power, 2017-06-14 19:11:22]

Description was changed from

==========
[ObjC ARC] Converts ios/web:ios_web_web_state_ui_unittests to ARC.

Automatically generated ARCMigrate commit

Notable issues:

Removed WKBackForwardListItemHolderTest.GetNilBackForwardListItemFromHolder,
since it amounts to being a test of WeakNSPointer, and there's no guarantees
about
object lifetimes under ARC.

BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/web:ios_web_web_state_ui_unittests to ARC.

Automatically generated ARCMigrate commit

Notable issues:

Removed WKBackForwardListItemHolderTest.GetNilBackForwardListItemFromHolder,
since it amounts to being a test of WeakNSPointer, and there's no guarantees
about
object lifetimes under ARC.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2933363002
Cr-Commit-Position: refs/heads/master@{#479462}
Committed:
https://chromium.googlesource.com/chromium/src/+/e903119df72bd16ed4682c9e1c88...
==========

[commit-bot: I haz the power, 2017-06-14 19:11:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e903119df72bd16ed4682c9e1c88...